NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitaae12e4

committed

Reject ANALYZE commands during VACUUM FULL or another ANALYZE.

vacuum()'s static variable handling makes it non-reentrant; an ensuingnull pointer deference crashed the backend. Back-patch to 9.0 (allsupported versions).

1 parentcbb2d9d commitaae12e4Copy full SHA for aae12e4

File tree

3 files changed

+33

-4

lines changed

src
- backend/commands
  - vacuum.c
- test/regress
  - expected
    - vacuum.out
  - sql
    - vacuum.sql

3 files changed

+33

-4

lines changed

`‎src/backend/commands/vacuum.c`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ vacuum(VacuumStmt *vacstmt, Oid relid, bool do_toast,`
`99`	`99`	`in_outer_xact,`
`100`	`100`	`use_own_xacts;`
`101`	`101`	`List*relations;`
	`102`	`+staticboolin_vacuum= false;`
`102`	`103`
`103`	`104`	`/* sanity checks on options */`
`104`	`105`	`Assert(vacstmt->options& (VACOPT_VACUUM \|VACOPT_ANALYZE));`
`@@ -124,6 +125,14 @@ vacuum(VacuumStmt *vacstmt, Oid relid, bool do_toast,`
`124`	`125`	`else`
`125`	`126`	`in_outer_xact=IsInTransactionChain(isTopLevel);`
`126`	`127`
	`128`	`+/*`
	`129`	`+ * Due to static variables vac_context, anl_context and vac_strategy,`
	`130`	`+ * vacuum() is not reentrant. This matters when VACUUM FULL or ANALYZE`
	`131`	`+ * calls a hostile index expression that itself calls ANALYZE.`
	`132`	`+ */`
	`133`	`+if (in_vacuum)`
	`134`	`+elog(ERROR,"%s cannot be executed from VACUUM or ANALYZE",stmttype);`
	`135`	`+`
`127`	`136`	`/*`
`128`	`137`	`* Send info about dead objects to the statistics collector, unless we are`
`129`	`138`	`* in autovacuum --- autovacuum.c does this for itself.`
`@@ -219,6 +228,7 @@ vacuum(VacuumStmt *vacstmt, Oid relid, bool do_toast,`
`219`	`228`	`{`
`220`	`229`	`ListCell*cur;`
`221`	`230`
	`231`	`+in_vacuum= true;`
`222`	`232`	`VacuumCostActive= (VacuumCostDelay>0);`
`223`	`233`	`VacuumCostBalance=0;`
`224`	`234`
`@@ -257,13 +267,13 @@ vacuum(VacuumStmt *vacstmt, Oid relid, bool do_toast,`
`257`	`267`	`}`
`258`	`268`	`PG_CATCH();`
`259`	`269`	`{`
`260`		`-/* Make sure cost accounting is turned off after error */`
	`270`	`+in_vacuum= false;`
`261`	`271`	`VacuumCostActive= false;`
`262`	`272`	`PG_RE_THROW();`
`263`	`273`	`}`
`264`	`274`	`PG_END_TRY();`
`265`	`275`
`266`		`-/* Turn off vacuum cost accounting */`
	`276`	`+in_vacuum= false;`
`267`	`277`	`VacuumCostActive= false;`
`268`	`278`
`269`	`279`	`/*`

`‎src/test/regress/expected/vacuum.out`

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -61,12 +61,24 @@ VACUUM (ANALYZE, FULL) vactst;`
`61`	`61`	`CREATE TABLE vaccluster (i INT PRIMARY KEY);`
`62`	`62`	`NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "vaccluster_pkey" for table "vaccluster"`
`63`	`63`	`ALTER TABLE vaccluster CLUSTER ON vaccluster_pkey;`
`64`		`-INSERT INTO vaccluster SELECT * FROM vactst;`
`65`	`64`	`CLUSTER vaccluster;`
	`65`	`+CREATE FUNCTION do_analyze() RETURNS VOID VOLATILE LANGUAGE SQL`
	`66`	`+AS 'ANALYZE pg_am';`
	`67`	`+CREATE FUNCTION wrap_do_analyze(c INT) RETURNS INT IMMUTABLE LANGUAGE SQL`
	`68`	`+AS 'SELECT $1 FROM do_analyze()';`
	`69`	`+CREATE INDEX ON vactst(wrap_do_analyze(i));`
	`70`	`+INSERT INTO vactst VALUES (1), (2);`
	`71`	`+ANALYZE vactst;`
	`72`	`+ERROR: ANALYZE cannot be executed from VACUUM or ANALYZE`
	`73`	`+CONTEXT: SQL function "do_analyze" statement 1`
	`74`	`+SQL function "wrap_do_analyze" statement 1`
`66`	`75`	`VACUUM FULL pg_am;`
`67`	`76`	`VACUUM FULL pg_class;`
`68`	`77`	`VACUUM FULL pg_database;`
`69`	`78`	`VACUUM FULL vaccluster;`
`70`	`79`	`VACUUM FULL vactst;`
	`80`	`+ERROR: ANALYZE cannot be executed from VACUUM or ANALYZE`
	`81`	`+CONTEXT: SQL function "do_analyze" statement 1`
	`82`	`+SQL function "wrap_do_analyze" statement 1`
`71`	`83`	`DROP TABLE vaccluster;`
`72`	`84`	`DROP TABLE vactst;`

`‎src/test/regress/sql/vacuum.sql`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,16 @@ VACUUM (ANALYZE, FULL) vactst;`
`44`	`44`
`45`	`45`	`CREATETABLEvaccluster (iINTPRIMARY KEY);`
`46`	`46`	`ALTERTABLE vaccluster CLUSTERON vaccluster_pkey;`
`47`		`-INSERT INTO vacclusterSELECT*FROM vactst;`
`48`	`47`	`CLUSTER vaccluster;`
`49`	`48`
	`49`	`+CREATEFUNCTIONdo_analyze() RETURNS VOID VOLATILE LANGUAGE SQL`
	`50`	`+AS'ANALYZE pg_am';`
	`51`	`+CREATEFUNCTIONwrap_do_analyze(cINT) RETURNSINT IMMUTABLE LANGUAGE SQL`
	`52`	`+AS'SELECT $1 FROM do_analyze()';`
	`53`	`+CREATEINDEXON vactst(wrap_do_analyze(i));`
	`54`	`+INSERT INTO vactstVALUES (1), (2);`
	`55`	`+ANALYZE vactst;`
	`56`	`+`
`50`	`57`	`VACUUM FULL pg_am;`
`51`	`58`	`VACUUM FULL pg_class;`
`52`	`59`	`VACUUM FULL pg_database;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaae12e4

File tree

3 files changed

3 files changed

`‎src/backend/commands/vacuum.c`

`‎src/test/regress/expected/vacuum.out`

`‎src/test/regress/sql/vacuum.sql`

0 commit comments