NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita9a8108

committed

Remove test for pg_stat_reset_shared() in stats.sql

Some buildfarm members have been failing a test related to pg_stat_io,as an effect of23c8c0c that has switched pg_stat_reset_shared()from being a no-op to reset all shared stats types.This extra reset has the effect to make pg_stat_io's counters low enoughthat little concurrent activity is enough to cause a failure. Anotherthing I have considered is to move this sequence at the end ofstats.sql, but there are other instabilities, one being pg_stat_wal.Knowing that there are already tests for the reset of each individualshared stats target, this test has limited value, so let's remove it tominimize the number of resets done for each shared stats type. Thisshould hopefully improve the stability of the whole.Discussion:https://postgr.es/m/3500949.1700935734@sss.pgh.pa.us

1 parent5ad4932 commita9a8108Copy full SHA for a9a8108

File tree

2 files changed

-54

lines changed

src/test/regress
- expected
  - stats.out
- sql
  - stats.sql

2 files changed

-54

lines changed

`‎src/test/regress/expected/stats.out`

Lines changed: 0 additions & 44 deletions

Original file line number	Diff line number	Diff line change
`@@ -990,50 +990,6 @@ SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;`
`990`	`990`	`(1 row)`
`991`	`991`
`992`	`992`	`SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset`
`993`		`--- Test that reset_shared with no argument resets all the stats types`
`994`		`--- supported (providing NULL as argument has the same effect).`
`995`		`-SELECT pg_stat_reset_shared();`
`996`		`- pg_stat_reset_shared`
`997`		`-----------------------`
`998`		`-`
`999`		`-(1 row)`
`1000`		`-`
`1001`		`-SELECT stats_reset > :'archiver_reset_ts'::timestamptz FROM pg_stat_archiver;`
`1002`		`- ?column?`
`1003`		`-----------`
`1004`		`- t`
`1005`		`-(1 row)`
`1006`		`-`
`1007`		`-SELECT stats_reset > :'bgwriter_reset_ts'::timestamptz FROM pg_stat_bgwriter;`
`1008`		`- ?column?`
`1009`		`-----------`
`1010`		`- t`
`1011`		`-(1 row)`
`1012`		`-`
`1013`		`-SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpointer;`
`1014`		`- ?column?`
`1015`		`-----------`
`1016`		`- t`
`1017`		`-(1 row)`
`1018`		`-`
`1019`		`-SELECT stats_reset > :'recovery_prefetch_reset_ts'::timestamptz FROM pg_stat_recovery_prefetch;`
`1020`		`- ?column?`
`1021`		`-----------`
`1022`		`- t`
`1023`		`-(1 row)`
`1024`		`-`
`1025`		`-SELECT max(stats_reset) > :'slru_reset_ts'::timestamptz FROM pg_stat_slru;`
`1026`		`- ?column?`
`1027`		`-----------`
`1028`		`- t`
`1029`		`-(1 row)`
`1030`		`-`
`1031`		`-SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;`
`1032`		`- ?column?`
`1033`		`-----------`
`1034`		`- t`
`1035`		`-(1 row)`
`1036`		`-`
`1037`	`993`	`-- Test error case for reset_shared with unknown stats type`
`1038`	`994`	`SELECT pg_stat_reset_shared('unknown');`
`1039`	`995`	`ERROR: unrecognized reset target: "unknown"`

`‎src/test/regress/sql/stats.sql`

Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -494,16 +494,6 @@ SELECT pg_stat_reset_shared('wal');`
`494`	`494`	`SELECT stats_reset> :'wal_reset_ts'::timestamptzFROM pg_stat_wal;`
`495`	`495`	`SELECT stats_resetAS wal_reset_tsFROM pg_stat_wal \gset`
`496`	`496`
`497`		`--- Test that reset_shared with no argument resets all the stats types`
`498`		`--- supported (providing NULL as argument has the same effect).`
`499`		`-SELECT pg_stat_reset_shared();`
`500`		`-SELECT stats_reset> :'archiver_reset_ts'::timestamptzFROM pg_stat_archiver;`
`501`		`-SELECT stats_reset> :'bgwriter_reset_ts'::timestamptzFROM pg_stat_bgwriter;`
`502`		`-SELECT stats_reset> :'checkpointer_reset_ts'::timestamptzFROM pg_stat_checkpointer;`
`503`		`-SELECT stats_reset> :'recovery_prefetch_reset_ts'::timestamptzFROM pg_stat_recovery_prefetch;`
`504`		`-SELECTmax(stats_reset)> :'slru_reset_ts'::timestamptzFROM pg_stat_slru;`
`505`		`-SELECT stats_reset> :'wal_reset_ts'::timestamptzFROM pg_stat_wal;`
`506`		`-`
`507`	`497`	`-- Test error case for reset_shared with unknown stats type`
`508`	`498`	`SELECT pg_stat_reset_shared('unknown');`
`509`	`499`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita9a8108

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/stats.out`

`‎src/test/regress/sql/stats.sql`

0 commit comments