NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita949b73

committed

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, becausewe weren't expecting there to be no database name supplied.It doesn't seem like a great idea to run regression testsin whatever is the user's default database; so rather thansupporting this case let's explicitly reject it.Per report from Xing Guo. Back-patch to all supportedbranches.Discussion:https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

1 parent5d208b9 commita949b73Copy full SHA for a949b73

File tree

1 file changed

+11

-0

lines changed

src/test/regress
- pg_regress.c

1 file changed

+11

-0

lines changed

`‎src/test/regress/pg_regress.c`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2308,6 +2308,17 @@ regression_main(int argc, char *argv[],`
`2308`	`2308`	`optind++;`
`2309`	`2309`	`}`
`2310`	`2310`
	`2311`	`+/*`
	`2312`	`+ * We must have a database to run the tests in; either a default name, or`
	`2313`	`+ * one supplied by the --dbname switch.`
	`2314`	`+ */`
	`2315`	`+if (!(dblist&&dblist->str&&dblist->str[0]))`
	`2316`	`+{`
	`2317`	`+fprintf(stderr,_("%s: no database name was specified\n"),`
	`2318`	`+progname);`
	`2319`	`+exit(2);`
	`2320`	`+}`
	`2321`	`+`
`2311`	`2322`	`if (config_auth_datadir)`
`2312`	`2323`	`{`
`2313`	`2324`	`#ifdefENABLE_SSPI`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita949b73

File tree

1 file changed

1 file changed

`‎src/test/regress/pg_regress.c`

0 commit comments