Commita8fb03f

committed

Improve error reporting for unsupported effective_io_concurrency setting.

Give a specific error complaining about lack of posix_fadvise() whensomeone tries to set effective_io_concurrency > 0 on platformswithout that.This probably isn't worth extensive back-patching, but I (tgl) feltcramming it into v11 was reasonable.James RobinsonDiscussion:https://postgr.es/m/153771876450.14994.560017943128223619@wrigleys.postgresql.orgDiscussion:https://postgr.es/m/A3942987-5BC7-4F05-B54D-2A0EC2914B33@jlr-photo.com

1 parent6c8671b commita8fb03fCopy full SHA for a8fb03f

File tree

+11

-3

lines changed

+11

-3

lines changed

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2641,10 +2641,11 @@ static struct config_int ConfigureNamesInt[] =`
`2641`	`2641`	`},`
`2642`	`2642`	`&effective_io_concurrency,`
`2643`	`2643`	`#ifdefUSE_PREFETCH`
`2644`		`-1,0,MAX_IO_CONCURRENCY,`
	`2644`	`+1,`
`2645`	`2645`	`#else`
`2646`		`-0,0,0,`
	`2646`	`+0,`
`2647`	`2647`	`#endif`
	`2648`	`+0,MAX_IO_CONCURRENCY,`
`2648`	`2649`	`check_effective_io_concurrency,assign_effective_io_concurrency,NULL`
`2649`	`2650`	`},`
`2650`	`2651`
`@@ -10681,6 +10682,11 @@ check_effective_io_concurrency(int newval, void *extra, GucSource source)`
`10681`	`10682`	`else`
`10682`	`10683`	`return false;`
`10683`	`10684`	`#else`
	`10685`	`+if (*newval!=0)`
	`10686`	`+{`
	`10687`	`+GUC_check_errdetail("effective_io_concurrency must be set to 0 on platforms that lack posix_fadvise()");`
	`10688`	`+return false;`
	`10689`	`+}`
`10684`	`10690`	`return true;`
`10685`	`10691`	`#endif/* USE_PREFETCH */`
`10686`	`10692`	`}`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,9 @@`
`136`	`136`	`/*`
`137`	`137`	`* USE_PREFETCH code should be compiled only if we have a way to implement`
`138`	`138`	`* prefetching. (This is decoupled from USE_POSIX_FADVISE because there`
`139`		`- * might in future be support for alternative low-level prefetch APIs.)`
	`139`	`+ * might in future be support for alternative low-level prefetch APIs.`
	`140`	`+ * If you change this, you probably need to adjust the error message in`
	`141`	`+ * check_effective_io_concurrency.)`
`140`	`142`	`*/`
`141`	`143`	`#ifdefUSE_POSIX_FADVISE`
`142`	`144`	`#defineUSE_PREFETCH`

Comments

(0)