NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita8aa2f9

Thomas G. Lockhart

committed

Repair always-broken date_part('quarter',timestamp).

Previous result did not have correct month boundaries so anything near edge cases was suspect (e.g. April was in Q1 and July, August were lumped into Q2).Thanks to Denis Osadchy <osadchy@turbo.nsk.su> for the report.

1 parent39f987c commita8aa2f9Copy full SHA for a8aa2f9

File tree

1 file changed

-5

lines changed

src/backend/utils/adt
- timestamp.c

1 file changed

-5

lines changed

`‎src/backend/utils/adt/timestamp.c‎`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/timestamp.c,v 1.40 2000/12/07 18:38:59 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/timestamp.c,v 1.41 2001/01/03 16:48:02 thomas Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1887,9 +1887,9 @@ interval_trunc(PG_FUNCTION_ARGS)`
`1887`	`1887`	`}`
`1888`	`1888`
`1889`	`1889`	`/* isoweek2date()`
`1890`		`- *`
`1891`		`- *Convert ISO week ofyearnumber to date. An yearmust bealready set.`
`1892`		`- *karel 2000/08/07`
	`1890`	`+ * Convert ISO week of year number to date.`
	`1891`	`+ *Theyearfieldmust bespecified!`
	`1892`	`+ *karel 2000/08/07`
`1893`	`1893`	`*/`
`1894`	`1894`	`void`
`1895`	`1895`	`isoweek2date(intwoy,intyear,intmon,int*mday)`
`@@ -2053,7 +2053,7 @@ timestamp_part(PG_FUNCTION_ARGS)`
`2053`	`2053`	`break;`
`2054`	`2054`
`2055`	`2055`	`caseDTK_QUARTER:`
`2056`		`-result= (tm->tm_mon/4)+1;`
	`2056`	`+result= ((tm->tm_mon-1) /3)+1;`
`2057`	`2057`	`break;`
`2058`	`2058`
`2059`	`2059`	`caseDTK_WEEK:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita8aa2f9

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/timestamp.c‎`

0 commit comments