NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita88a18b

committed

Assert only valid flag bits are passed to visibilitymap_set()

If visibilitymap_set() is called with flags containing a higher bit thanVISIBILITYMAP_ALL_FROZEN, the state of neighboring pages is affected. Whilethere was an assertion that *some* valid bits were set, it did not checkthat *only* valid bits were. Change that.Discussion:https://postgr.es/m/20230331043300.gux3s5wzrapqi4oe@awork3.anarazel.de

1 parent14f98e0 commita88a18bCopy full SHA for a88a18b

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- visibilitymap.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/visibilitymap.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -259,9 +259,9 @@ visibilitymap_set(Relation rel, BlockNumber heapBlk, Buffer heapBuf,`
`259`	`259`
`260`	`260`	`Assert(InRecovery\|\|XLogRecPtrIsInvalid(recptr));`
`261`	`261`	`Assert(InRecovery\|\|PageIsAllVisible((Page)BufferGetPage(heapBuf)));`
	`262`	`+Assert((flags&VISIBILITYMAP_VALID_BITS)==flags);`
`262`	`263`
`263`	`264`	`/* Must never set all_frozen bit without also setting all_visible bit */`
`264`		`-Assert(flags&VISIBILITYMAP_VALID_BITS);`
`265`	`265`	`Assert(flags!=VISIBILITYMAP_ALL_FROZEN);`
`266`	`266`
`267`	`267`	`/* Check that we have the right heap page pinned, if present */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita88a18b

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/visibilitymap.c`

0 commit comments