forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commita82ba06
committed
Remove erroneous assertion from pg_copy_logical_replication_slot().
If restart_lsn of logical replication slot gets behind more thanmax_slot_wal_keep_size from the current LSN, the logical replication slotwould be invalidated and its restart_lsn is reset to an invalid LSN.If this logical replication slot with an invalid restart_lsn was specified asthe source slot in pg_copy_logical_replication_slot(), the function causedthe assertion failure unexpectedly.This assertion was added because restart_lsn should not be invalid before.But in v13, it can be invalid thanks to max_slot_wal_keep_size. So since thisassertion is no longer useful, this commit removes it.This commit also changes the errcode in the error message thatpg_copy_logical_replication_slot() emits when the slot with an invalidrestart_lsn is specified, to more appropriate one.Back-patch to v13 where max_slot_wal_keep_size was added andthe assertion was no longer valid.Author: Fujii MasaoReviewed-by: Alvaro Herrera, Kyotaro HoriguchiDiscussion:https://postgr.es/m/f91de4fb-a7ab-b90e-8132-74796e049d51@oss.nttdata.com1 parent235c0f6 commita82ba06
1 file changed
+1
-4
lines changedLines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
755 | 755 | | |
756 | 756 | | |
757 | 757 | | |
758 | | - | |
759 | | - | |
760 | 758 | | |
761 | | - | |
| 759 | + | |
762 | 760 | | |
763 | | - | |
764 | 761 | | |
765 | 762 | | |
766 | 763 | | |
| |||
0 commit comments
Comments
(0)