forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commita7dc63d
committed
Refactor geometric functions and operators
The primary goal of this patch is to eliminate duplicate code and sharecode between different geometric data types more often, to prepare theground for additional patches. Until now the code reuse was limited,probably because the simpler types (line and point) were implementedafter the more complex ones.The changes are quite extensive and can be summarised as:* Eliminate SQL-level function calls.* Re-use more functions to implement others.* Unify internal function names and signatures.* Remove private functions from geo_decls.h.* Replace should-not-happen checks with assertions.* Add comments describe for various functions.* Remove some unreachable code.* Define delimiter symbols of line datatype like the other ones.* Remove the GEODEBUG macro and printf() calls.* Unify code style of a few oddly formatted lines.While the goal was to cause minimal user-visible changes, it was notpossible to keep the original behavior in all cases - for example whenhandling NaN values, or when reusing code makes the functions returnconsistent results.Author: Emre HasegeliReviewed-by: Kyotaro Horiguchi, meDiscussion:https://www.postgresql.org/message-id/CAE2gYzxF7-5djV6-cEvqQu-fNsnt%3DEqbOURx7ZDg%2BVv6ZMTWbg%40mail.gmail.com1 parentfa7d5b7 commita7dc63d
File tree
4 files changed
+870
-1026
lines changed- src
- backend/utils/adt
- include/utils
- test/regress
4 files changed
+870
-1026
lines changed0 commit comments
Comments
(0)