Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita7cfd65

Browse files
committed
Fixes:
Select queries with an isnull or notnull clause, like "select * wheresomefield isnull", crash the backend if the table has at least one index.If the indices are deleted the queries work again. Also the explaincommand fail in the same way.The is caused by a bug in subroutine of the optimizer which doesn't checknull values in the clauses.Submitted by: Massimo Dal Zotto <dz@cs.unitn.it>
1 parent3704b99 commita7cfd65

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

‎src/backend/optimizer/path/indxpath.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.1.1.1 1996/07/09 06:21:35 scrappy Exp $
11+
* $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.2 1996/07/19 07:13:26 scrappy Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -493,7 +493,7 @@ match_clause_to_indexkey(Rel *rel,
493493
/*
494494
* Check for standard s-argable clause
495495
*/
496-
if (IsA(rightop,Const))
496+
if (rightop&&IsA(rightop,Const))
497497
{
498498
restrict_op= ((Oper*)((Expr*)clause)->oper)->opno;
499499
isIndexable=
@@ -507,7 +507,7 @@ match_clause_to_indexkey(Rel *rel,
507507
/*
508508
* Must try to commute the clause to standard s-arg format.
509509
*/
510-
elseif (IsA(leftop,Const))
510+
elseif (leftop&&IsA(leftop,Const))
511511
{
512512
restrict_op=
513513
get_commutator(((Oper*)((Expr*)clause)->oper)->opno);
@@ -535,12 +535,14 @@ match_clause_to_indexkey(Rel *rel,
535535
*/
536536
else
537537
{
538-
if (match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {
538+
if (rightop
539+
&&match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {
539540

540541
join_op=get_commutator(((Oper*)((Expr*)clause)->oper)->opno);
541542

542-
}elseif (match_index_to_operand(indexkey,
543-
(Expr*)leftop,rel,index)) {
543+
}elseif (leftop
544+
&&match_index_to_operand(indexkey,
545+
(Expr*)leftop,rel,index)) {
544546
join_op= ((Oper*)((Expr*)clause)->oper)->opno;
545547
}
546548

‎src/backend/utils/adt/varlena.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.2 1996/07/1906:08:21 scrappy Exp $
10+
* $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.3 1996/07/1907:14:14 scrappy Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -198,8 +198,6 @@ textout(struct varlena *vlena)
198198

199199
/* ========== PUBLIC ROUTINES ========== */
200200

201-
/*
202-
203201
/*
204202
* textlen -
205203
* returns the actual length of a text* (which may be less than

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp