NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita7bcf39

committed

Remove useless lstat() call in pg_rewind.

This is duplicative of an lstat that was just done by the callingfunction (traverse_datadir), besides which we weren't really doinganything with the results. There's not much point in checking tosee if someone removed the file since the previous lstat, since theFILE_ACTION_REMOVE code would have to deal with missing-file casesanyway. Moreover, the "exists = false" assignment was a dead store;nothing was done with that value later.A syscall saved is a syscall earned, so back-patch to 9.5where this code was introduced.Discussion:https://postgr.es/m/1221796.1599329320@sss.pgh.pa.us

1 parentfc37c6f commita7bcf39Copy full SHA for a7bcf39

File tree

1 file changed

-12

lines changed

src/bin/pg_rewind
- filemap.c

1 file changed

-12

lines changed

`‎src/bin/pg_rewind/filemap.c`

Lines changed: 0 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -342,8 +342,6 @@ process_target_file(const char *path, file_type_t type, size_t oldsize,`
`342`	`342`	`constchar*link_target)`
`343`	`343`	`{`
`344`	`344`	`boolexists;`
`345`		`-charlocalpath[MAXPGPATH];`
`346`		`-structstatstatbuf;`
`347`	`345`	`file_entry_tkey;`
`348`	`346`	`file_entry_t*key_ptr;`
`349`	`347`	`filemap_t*map=filemap;`
`@@ -355,16 +353,6 @@ process_target_file(const char *path, file_type_t type, size_t oldsize,`
`355`	`353`	`* the source data folder when processing the source files.`
`356`	`354`	`*/`
`357`	`355`
`358`		`-snprintf(localpath,sizeof(localpath),"%s/%s",datadir_target,path);`
`359`		`-if (lstat(localpath,&statbuf)<0)`
`360`		`-{`
`361`		`-if (errno!=ENOENT)`
`362`		`-pg_fatal("could not stat file \"%s\": %m",`
`363`		`-localpath);`
`364`		`-`
`365`		`-exists= false;`
`366`		`-}`
`367`		`-`
`368`	`356`	`if (map->array==NULL)`
`369`	`357`	`{`
`370`	`358`	`/* on first call, initialize lookup array */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita7bcf39

File tree

1 file changed

1 file changed

`‎src/bin/pg_rewind/filemap.c`

0 commit comments