NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita79ed10

committed

Fix comment on processes being kept over a restart

All child processes except the syslogger are killed on a restart. Thearchiver might be already running though, if it was started duringrecovery.The split in the comments between "other special children" and thefirst group of "background tasks" seemed really arbitrary, so I justmerged them all into one group.Reviewed-by: Thomas Munro <thomas.munro@gmail.com>Discussion:https://www.postgresql.org/message-id/8f2118b9-79e3-4af7-b2c9-bd5818193ca4@iki.fi

1 parent28a520c commita79ed10Copy full SHA for a79ed10

File tree

1 file changed

-10

lines changed

src/backend/postmaster
- postmaster.c

1 file changed

-10

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 3 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -2386,9 +2386,9 @@ process_pm_child_exit(void)`
`2386`	`2386`	`connsAllowed= true;`
`2387`	`2387`
`2388`	`2388`	`/*`
`2389`		`- * Crank upthe background tasks, if we didn'tdo that already`
`2390`		`- *when we entered consistent recovery state. It doesn't matter`
`2391`		`- *if this fails, we'll justtry again later.`
	`2389`	`+ * Crank upany background tasks that we didn'tstart earlier`
	`2390`	`+ *already. It doesn't matter if any of these fail, we'll just`
	`2391`	`+ * try again later.`
`2392`	`2392`	`*/`
`2393`	`2393`	`if (CheckpointerPID==0)`
`2394`	`2394`	`CheckpointerPID=StartChildProcess(B_CHECKPOINTER);`
`@@ -2397,18 +2397,11 @@ process_pm_child_exit(void)`
`2397`	`2397`	`if (WalWriterPID==0)`
`2398`	`2398`	`WalWriterPID=StartChildProcess(B_WAL_WRITER);`
`2399`	`2399`	`MaybeStartWalSummarizer();`
`2400`		`-`
`2401`		`-/*`
`2402`		`- * Likewise, start other special children as needed. In a restart`
`2403`		`- * situation, some of them may be alive already.`
`2404`		`- */`
`2405`	`2400`	`if (!IsBinaryUpgrade&&AutoVacuumingActive()&&AutoVacPID==0)`
`2406`	`2401`	`AutoVacPID=StartChildProcess(B_AUTOVAC_LAUNCHER);`
`2407`	`2402`	`if (PgArchStartupAllowed()&&PgArchPID==0)`
`2408`	`2403`	`PgArchPID=StartChildProcess(B_ARCHIVER);`
`2409`	`2404`	`MaybeStartSlotSyncWorker();`
`2410`		`-`
`2411`		`-/* workers may be scheduled to start now */`
`2412`	`2405`	`maybe_start_bgworkers();`
`2413`	`2406`
`2414`	`2407`	`/* at this point we are really open for business */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita79ed10

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/postmaster.c`

0 commit comments