NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita766d6c

committed

Avoid harmless Valgrind no-buffer-pin errors.

Valgrind builds with assertions enabled sometimes perform atheoretically unsafe page access inside an assertion inheapam_tuple_lock(). This happened when the eval-plan-qual isolationtest ran one of the permutations added by commita2418f9.Avoid complaints from Valgrind by moving the assertion ever so slightly.This is minor cleanup for commit1e0dfd1, which added Valgrind bufferaccess instrumentation.No backpatch, since this only happens within an assertion, and seemsvery unlikely to cause any real problems even with assert-enabledbuilds.

1 parent46ef520 commita766d6cCopy full SHA for a766d6c

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam_handler.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam_handler.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -368,10 +368,11 @@ heapam_tuple_lock(Relation relation, ItemPointer tid, Snapshot snapshot,`
`368`	`368`	`if (result==TM_Updated&&`
`369`	`369`	`(flags&TUPLE_LOCK_FLAG_FIND_LAST_VERSION))`
`370`	`370`	`{`
`371`		`-ReleaseBuffer(buffer);`
`372`	`371`	`/* Should not encounter speculative tuple on recheck */`
`373`	`372`	`Assert(!HeapTupleHeaderIsSpeculative(tuple->t_data));`
`374`	`373`
	`374`	`+ReleaseBuffer(buffer);`
	`375`	`+`
`375`	`376`	`if (!ItemPointerEquals(&tmfd->ctid,&tuple->t_self))`
`376`	`377`	`{`
`377`	`378`	`SnapshotDataSnapshotDirty;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita766d6c

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam_handler.c`

0 commit comments