Commita6896e0

committed

Remove unnecessary check for jbvBinary in convertJsonbValue.

The check was confusing and is a condition that should never in facthappen.Per gripe from Dmitry Dolgov.

1 parentfd1afbb commita6896e0Copy full SHA for a6896e0

File tree

-1

lines changed

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1314,7 +1314,14 @@ convertJsonbValue(StringInfo buffer, JEntry header, JsonbValue val, int level)`
`1314`	`1314`	`if (!val)`
`1315`	`1315`	`return;`
`1316`	`1316`
`1317`		`-if (IsAJsonbScalar(val)\|\|val->type==jbvBinary)`
	`1317`	`+/*`
	`1318`	`+ * A JsonbValue passed as val should never have a type of jbvBinary,`
	`1319`	`+ * and neither should any of its sub-components. Those values will be`
	`1320`	`+ * produced by convertJsonbArray and convertJsonbObject, the results of`
	`1321`	`+ * which will not be passed back to this function as an argument.`
	`1322`	`+ */`
	`1323`	`+`
	`1324`	`+if (IsAJsonbScalar(val))`
`1318`	`1325`	`convertJsonbScalar(buffer,header,val);`
`1319`	`1326`	`elseif (val->type==jbvArray)`
`1320`	`1327`	`convertJsonbArray(buffer,header,val,level);`

Comments

(0)