NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita65b297

committed

Add a stack overflow check to copyObject().

There are some code paths, such as SPI_execute(), where we invokecopyObject() on raw parse trees before doing parse analysis on them. Sincethe bison grammar is capable of building heavily nested parsetrees whileitself using only minimal stack depth, this means that copyObject() can bethe front-line function that hits stack overflow before anything else does.Accordingly, it had better have a check_stack_depth() call. I did a bit ofperformance testing and found that this slows down copyObject() by only afew percent, so the hit ought to be negligible in the context of completeprocessing of a query.Per off-list report from Toshihide Katayama. Back-patch to all supportedbranches.

1 parente116bcf commita65b297Copy full SHA for a65b297

File tree

1 file changed

-0

lines changed

src/backend/nodes
- copyfuncs.c

1 file changed

-0

lines changed

`‎src/backend/nodes/copyfuncs.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`
`23`	`23`	`#include"postgres.h"`
`24`	`24`
	`25`	`+#include"miscadmin.h"`
`25`	`26`	`#include"nodes/plannodes.h"`
`26`	`27`	`#include"nodes/relation.h"`
`27`	`28`	`#include"utils/datum.h"`
`@@ -3570,6 +3571,9 @@ copyObject(void *from)`
`3570`	`3571`	`if (from==NULL)`
`3571`	`3572`	`returnNULL;`
`3572`	`3573`
	`3574`	`+/* Guard against stack overflow due to overly complex expressions */`
	`3575`	`+check_stack_depth();`
	`3576`	`+`
`3573`	`3577`	`switch (nodeTag(from))`
`3574`	`3578`	`{`
`3575`	`3579`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita65b297

File tree

1 file changed

1 file changed

`‎src/backend/nodes/copyfuncs.c`

0 commit comments