NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita6380f8

committed

Print WAL position correctly in pg_rewind error message.

This has been wrong ever since pg_rewind was added. The if-branch justabove this, where we print the same error with an extra message suppliedby XLogReadRecord() got this right, but the variable name was wrong in theelse-branch. As a consequence, the error printed the WAL position as0/0 if there was an error reading a WAL file.Backpatch to 9.5, where pg_rewind was added.

1 parent4dbf70b commita6380f8Copy full SHA for a6380f8

File tree

1 file changed

-2

lines changed

src/bin/pg_rewind
- parsexlog.c

1 file changed

-2

lines changed

`‎src/bin/pg_rewind/parsexlog.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,7 @@ extractPageMap(const char *datadir, XLogRecPtr startpoint, int tliIndex,`
`90`	`90`	`errormsg);`
`91`	`91`	`else`
`92`	`92`	`pg_fatal("could not read WAL record at %X/%X\n",`
`93`		`- (uint32) (startpoint >>32),`
`94`		`- (uint32) (startpoint));`
	`93`	`+ (uint32) (errptr >>32), (uint32) (errptr));`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`extractPageInfo(xlogreader);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita6380f8

File tree

1 file changed

1 file changed

`‎src/bin/pg_rewind/parsexlog.c`

0 commit comments