Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita62bff7

Browse files
committed
Fix aggregate logging of pgbench.
Remove meaningless "failures" column from the aggregate logging. Itwas just a sum of "serialization failures" and "deadlock failures".Pointed out by Tom Lane. Patch reviewed by Fabien COELHO.Discussion:https://postgr.es/m/4183048.1649536705%40sss.pgh.pa.us
1 parentdd4ab6f commita62bff7

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

‎doc/src/sgml/ref/pgbench.sgml‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2591,15 +2591,6 @@ END;
25912591
</listitem>
25922592
</varlistentry>
25932593

2594-
<varlistentry>
2595-
<term><replaceable>failures</replaceable></term>
2596-
<listitem>
2597-
<para>
2598-
number of transactions that ended with a failed SQL command
2599-
</para>
2600-
</listitem>
2601-
</varlistentry>
2602-
26032594
<varlistentry>
26042595
<term><replaceable>serialization_failures</replaceable></term>
26052596
<listitem>
@@ -2629,8 +2620,8 @@ END;
26292620
<screen>
26302621
<userinput>pgbench --aggregate-interval=10 --time=20 --client=10 --log --rate=1000 --latency-limit=10 --failures-detailed --max-tries=10 test</userinput>
26312622

2632-
1649114136 5815 27552565 177846919143 1078 21716 2756787 7264696105 09661 0 7854 31472 4022 4022 0
2633-
1649114146 5958 28460110 182785513108 1083 20391 2539395 6411761497 07268 0 8127 32595 4101 4101 0
2623+
1650260552 5178 26171317 177284491527 1136 44462 2647617 7321113867 09866 64 7564 28340 4148 0
2624+
1650260562 4808 25573984 220121792172 1171 62083 3037380 9666800914 09998 598 7392 26621 4527 0
26342625
</screen>
26352626
</para>
26362627

‎src/bin/pgbench/pgbench.c‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4498,7 +4498,6 @@ doLog(TState *thread, CState *st,
44984498
int64skipped=0;
44994499
int64serialization_failures=0;
45004500
int64deadlock_failures=0;
4501-
int64serialization_or_deadlock_failures=0;
45024501
int64retried=0;
45034502
int64retries=0;
45044503

@@ -4540,9 +4539,7 @@ doLog(TState *thread, CState *st,
45404539
serialization_failures=agg->serialization_failures;
45414540
deadlock_failures=agg->deadlock_failures;
45424541
}
4543-
serialization_or_deadlock_failures=serialization_failures+deadlock_failures;
4544-
fprintf(logfile," "INT64_FORMAT" "INT64_FORMAT" "INT64_FORMAT,
4545-
serialization_or_deadlock_failures,
4542+
fprintf(logfile," "INT64_FORMAT" "INT64_FORMAT,
45464543
serialization_failures,
45474544
deadlock_failures);
45484545

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp