NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita587901

committed

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, becausewe weren't expecting there to be no database name supplied.It doesn't seem like a great idea to run regression testsin whatever is the user's default database; so rather thansupporting this case let's explicitly reject it.Per report from Xing Guo. Back-patch to all supportedbranches.Discussion:https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

1 parent7b96f52 commita587901Copy full SHA for a587901

File tree

1 file changed

+11

-0

lines changed

src/test/regress
- pg_regress.c

1 file changed

+11

-0

lines changed

`‎src/test/regress/pg_regress.c`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2257,6 +2257,17 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2257`	`2257`	`optind++;`
`2258`	`2258`	`}`
`2259`	`2259`
	`2260`	`+/*`
	`2261`	`+ * We must have a database to run the tests in; either a default name, or`
	`2262`	`+ * one supplied by the --dbname switch.`
	`2263`	`+ */`
	`2264`	`+if (!(dblist&&dblist->str&&dblist->str[0]))`
	`2265`	`+{`
	`2266`	`+fprintf(stderr,_("%s: no database name was specified\n"),`
	`2267`	`+progname);`
	`2268`	`+exit(2);`
	`2269`	`+}`
	`2270`	`+`
`2260`	`2271`	`if (config_auth_datadir)`
`2261`	`2272`	`{`
`2262`	`2273`	`#ifdefENABLE_SSPI`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita587901

File tree

1 file changed

1 file changed

`‎src/test/regress/pg_regress.c`

0 commit comments