NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita57695d

committed

Fix detection of unfinished Unicode surrogate pair at end of string.

The U&'...' and U&"..." syntaxes silently discarded a surrogate pairstart (that is, a code between U+D800 and U+DBFF) if it occurred atthe very end of the string. This seems like an obvious oversight,since we throw an error for every other invalid combination of surrogatecharacters, including the very same situation in E'...' syntax.This has been wrong since the pair processing was added (in 9.0),so back-patch to all supported branches.Discussion:https://postgr.es/m/19113.1482337898@sss.pgh.pa.us

1 parent1f2cfd2 commita57695dCopy full SHA for a57695d

File tree

1 file changed

-0

lines changed

src/backend/parser
- scan.l

1 file changed

-0

lines changed

`‎src/backend/parser/scan.l`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1395,7 +1395,15 @@ litbuf_udeescape(unsigned char escape, core_yyscan_t yyscanner)`
`1395`	`1395`	`}`
`1396`	`1396`	`}`
`1397`	`1397`
	`1398`	`+/* unfinished surrogate pair? */`
	`1399`	`+if (pair_first)`
	`1400`	`+{`
	`1401`	`+ADVANCE_YYLLOC(in - litbuf +3);/* 3 for U&" */`
	`1402`	`+yyerror("invalid Unicode surrogate pair");`
	`1403`	`+}`
	`1404`	`+`
`1398`	`1405`	`*out ='\0';`
	`1406`	`+`
`1399`	`1407`	`/*`
`1400`	`1408`	`* We could skip pg_verifymbstr if we didn't process any non-7-bit-ASCII`
`1401`	`1409`	`* codes; but it's probably not worth the trouble, since this isn't`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita57695d

File tree

1 file changed

1 file changed

`‎src/backend/parser/scan.l`

0 commit comments