NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita54d587

committed

Guard against null t->tm_zone in strftime.c.

The upstream IANA code does not guard against null TM_ZONE pointers in thisfunction, but in our code there is such a check in the other pre-existinguse of t->tm_zone. We do have some places that set pg_tm.tm_zone to NULL.I'm not entirely sure it's possible to reach strftime with such a value,but I'm not sure it isn't either, so be safe.Per Coverity complaint.

1 parentd4e59c5 commita54d587Copy full SHA for a54d587

File tree

1 file changed

-1

lines changed

src/timezone
- strftime.c

1 file changed

-1

lines changed

`‎src/timezone/strftime.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,8 @@ _fmt(const char format, const struct pg_tm t, char pt, const char ptlim,`
`458`	`458`	`negative=diff<0;`
`459`	`459`	`if (diff==0)`
`460`	`460`	`{`
`461`		`-negative=t->tm_zone[0]=='-';`
	`461`	`+if (t->tm_zone!=NULL)`
	`462`	`+negative=t->tm_zone[0]=='-';`
`462`	`463`	`}`
`463`	`464`	`if (negative)`
`464`	`465`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita54d587

File tree

1 file changed

1 file changed

`‎src/timezone/strftime.c`

0 commit comments