NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita54129e

committed

Fix fallback implementation for pg_atomic_test_set_flag().

The fallback implementation of pg_atomic_test_set_flag() that usesatomic-exchange gives pg_atomic_exchange_u32_impl() an extraargument. This issue has been present since the introduction ofthe atomics API in commitb64d92f.Reviewed-by: Andres FreundDiscussion:https://postgr.es/m/20231114035439.GA1809032%40nathanxps13Backpatch-through: 12

1 parentc532be9 commita54129eCopy full SHA for a54129e

File tree

1 file changed

-1

lines changed

src/include/port/atomics
- generic.h

1 file changed

-1

lines changed

`‎src/include/port/atomics/generic.h‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ pg_atomic_init_flag_impl(volatile pg_atomic_flag *ptr)`
`83`	`83`	`staticinlinebool`
`84`	`84`	`pg_atomic_test_set_flag_impl(volatilepg_atomic_flag*ptr)`
`85`	`85`	`{`
`86`		`-returnpg_atomic_exchange_u32_impl(ptr,&value,1)==0;`
	`86`	`+returnpg_atomic_exchange_u32_impl(ptr,1)==0;`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`#definePG_HAVE_ATOMIC_UNLOCKED_TEST_FLAG`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita54129e

File tree

1 file changed

1 file changed

`‎src/include/port/atomics/generic.h‎`

0 commit comments