Commita4e1deb

committed

Remove command checks in tests of pg_basebackup and pg_receivewal

The TAP tests of those commands have been checking if commands of "gzip"and "lz4" existed by launching them with an extra --version. Based onthe buildfarm, this is not required for "gzip" as the command alwaysexists. Since1d084fb, "lz4" has a ./configure check doing the samething.Reported-by: Andres FreundDiscussion:https://postgr.es/m/20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.deDiscussion:https://postgr.es/m/Ygm2ADakjlqGc2Ro@paquier.xyz

1 parenta008496 commita4e1debCopy full SHA for a4e1deb

File tree

-9

lines changed

-9

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -767,9 +767,8 @@`
`767`	`767`	`# Check the integrity of the files generated.`
`768`	`768`	`my$gzip =$ENV{GZIP_PROGRAM};`
`769`	`769`	`skip"program gzip is not found in your system", 1`
`770`		`-if ( !defined$gzip`
`771`		`-\|\|$gzipeq''`
`772`		`-\|\| system_log($gzip,'--version') != 0);`
	`770`	`+if (!defined$gzip`
	`771`	`+\|\|$gzipeq'');`
`773`	`772`
`774`	`773`	`my$gzip_is_valid =`
`775`	`774`	`system_log($gzip,'--test',@zlib_files,@zlib_files2,@zlib_files3);`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,8 @@`
`129`	`129`	`# available.`
`130`	`130`	`my$gzip =$ENV{GZIP_PROGRAM};`
`131`	`131`	`skip"program gzip is not found in your system", 1`
`132`		`-if ( !defined$gzip`
`133`		`-\|\|$gzipeq''`
`134`		`-\|\| system_log($gzip,'--version') != 0);`
	`132`	`+if (!defined$gzip`
	`133`	`+\|\|$gzipeq'');`
`135`	`134`
`136`	`135`	`my$gzip_is_valid = system_log($gzip,'--test',@zlib_wals);`
`137`	`136`	`is($gzip_is_valid, 0,`
`@@ -185,9 +184,8 @@`
`185`	`184`	`# command.`
`186`	`185`	`my$lz4 =$ENV{LZ4};`
`187`	`186`	`skip"program lz4 is not found in your system", 1`
`188`		`-if ( !defined$lz4`
`189`		`-\|\|$lz4eq''`
`190`		`-\|\| system_log($lz4,'--version') != 0);`
	`187`	`+if (!defined$lz4`
	`188`	`+\|\|$lz4eq'');`
`191`	`189`
`192`	`190`	`my$lz4_is_valid = system_log($lz4,'-t',@lz4_wals);`
`193`	`191`	`is($lz4_is_valid, 0,`

Comments

(0)