Commita4d5284

committed

Error on invalid TOAST compression in CREATE or ALTER TABLE.

The previous coding treated an invalid compression method name asequivalent to the default, which is certainly not right.Justin PryzbyDiscussion:http://postgr.es/m/20210321235544.GD4203@telsasoft.com

1 parent24f0e39 commita4d5284Copy full SHA for a4d5284

File tree

+24

-3

lines changed

+24

-3

lines changed

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -17863,9 +17863,13 @@ GetAttributeCompression(Form_pg_attribute att, char *compression)`
`17863`	`17863`
`17864`	`17864`	`/* fallback to default compression if it's not specified */`
`17865`	`17865`	`if (compression == NULL)`
`17866`		`-cmethod = GetDefaultToastCompression();`
`17867`		`-else`
`17868`		`-cmethod = CompressionNameToMethod(compression);`
	`17866`	`+return GetDefaultToastCompression();`
	`17867`	`+`
	`17868`	`+cmethod = CompressionNameToMethod(compression);`
	`17869`	`+if (!CompressionMethodIsValid(cmethod))`
	`17870`	`+ereport(ERROR,`
	`17871`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`17872`	`+ errmsg("invalid compression method \"%s\"", compression)));`
`17869`	`17873`
`17870`	`17874`	`return cmethod;`
`17871`	`17875`	`}`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -347,4 +347,10 @@ SELECT length(f1) FROM cmmove3;`
`347`	`347`	`10040`
`348`	`348`	`(2 rows)`
`349`	`349`
	`350`	`+CREATE TABLE badcompresstbl (a text COMPRESSION I_Do_Not_Exist_Compression); -- fails`
	`351`	`+ERROR: invalid compression method "i_do_not_exist_compression"`
	`352`	`+CREATE TABLE badcompresstbl (a text);`
	`353`	`+ALTER TABLE badcompresstbl ALTER a SET COMPRESSION I_Do_Not_Exist_Compression; -- fails`
	`354`	`+ERROR: invalid compression method "i_do_not_exist_compression"`
	`355`	`+DROP TABLE badcompresstbl;`
`350`	`356`	`\set HIDE_TOAST_COMPRESSION true`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -340,4 +340,10 @@ SELECT length(f1) FROM cmmove3;`
`340`	`340`	`10000`
`341`	`341`	`(1 row)`
`342`	`342`
	`343`	`+CREATE TABLE badcompresstbl (a text COMPRESSION I_Do_Not_Exist_Compression); -- fails`
	`344`	`+ERROR: invalid compression method "i_do_not_exist_compression"`
	`345`	`+CREATE TABLE badcompresstbl (a text);`
	`346`	`+ALTER TABLE badcompresstbl ALTER a SET COMPRESSION I_Do_Not_Exist_Compression; -- fails`
	`347`	`+ERROR: invalid compression method "i_do_not_exist_compression"`
	`348`	`+DROP TABLE badcompresstbl;`
`343`	`349`	`\set HIDE_TOAST_COMPRESSION true`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -137,4 +137,9 @@ SELECT length(f1) FROM cmmove1;`
`137`	`137`	`SELECT length(f1)FROM cmmove2;`
`138`	`138`	`SELECT length(f1)FROM cmmove3;`
`139`	`139`
	`140`	`+CREATETABLEbadcompresstbl (atext COMPRESSION I_Do_Not_Exist_Compression);-- fails`
	`141`	`+CREATETABLEbadcompresstbl (atext);`
	`142`	`+ALTERTABLE badcompresstbl ALTER aSET COMPRESSION I_Do_Not_Exist_Compression;-- fails`
	`143`	`+DROPTABLE badcompresstbl;`
	`144`	`+`
`140`	`145`	`\set HIDE_TOAST_COMPRESSION true`

Comments

(0)