NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita49633d

committed

Fix WAL-logging of setting the visibility map bit.

The operation that removes the remaining dead tuples from the page mustbe WAL-logged before the setting of the VM bit. Otherwise, if you replaythe WAL to between those two records, you end up with the VM bit set, butthe dead tuples are still there.Backpatch to 9.3, where this bug was introduced.

1 parent4632891 commita49633dCopy full SHA for a49633d

File tree

1 file changed

+12

-15

lines changed

src/backend/commands
- vacuumlazy.c

1 file changed

+12

-15

lines changed

`‎src/backend/commands/vacuumlazy.c`

Lines changed: 12 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -1182,12 +1182,21 @@ lazy_vacuum_page(Relation onerel, BlockNumber blkno, Buffer buffer,`
`1182`	`1182`
`1183`	`1183`	`/*`
`1184`	`1184`	`* Mark buffer dirty before we write WAL.`
`1185`		`- *`
`1186`		`- * If checksums are enabled, visibilitymap_set() may log the heap page, so`
`1187`		`- * we must mark heap buffer dirty before calling visibilitymap_set().`
`1188`	`1185`	`*/`
`1189`	`1186`	`MarkBufferDirty(buffer);`
`1190`	`1187`
	`1188`	`+/* XLOG stuff */`
	`1189`	`+if (RelationNeedsWAL(onerel))`
	`1190`	`+{`
	`1191`	`+XLogRecPtrrecptr;`
	`1192`	`+`
	`1193`	`+recptr=log_heap_clean(onerel,buffer,`
	`1194`	`+NULL,0,NULL,0,`
	`1195`	`+unused,uncnt,`
	`1196`	`+vacrelstats->latestRemovedXid);`
	`1197`	`+PageSetLSN(page,recptr);`
	`1198`	`+}`
	`1199`	`+`
`1191`	`1200`	`/*`
`1192`	`1201`	`* Now that we have removed the dead tuples from the page, once again`
`1193`	`1202`	`* check if the page has become all-visible.`
`@@ -1201,18 +1210,6 @@ lazy_vacuum_page(Relation onerel, BlockNumber blkno, Buffer buffer,`
`1201`	`1210`	`visibility_cutoff_xid);`
`1202`	`1211`	`}`
`1203`	`1212`
`1204`		`-/* XLOG stuff */`
`1205`		`-if (RelationNeedsWAL(onerel))`
`1206`		`-{`
`1207`		`-XLogRecPtrrecptr;`
`1208`		`-`
`1209`		`-recptr=log_heap_clean(onerel,buffer,`
`1210`		`-NULL,0,NULL,0,`
`1211`		`-unused,uncnt,`
`1212`		`-vacrelstats->latestRemovedXid);`
`1213`		`-PageSetLSN(page,recptr);`
`1214`		`-}`
`1215`		`-`
`1216`	`1213`	`END_CRIT_SECTION();`
`1217`	`1214`
`1218`	`1215`	`returntupindex;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita49633d

File tree

1 file changed

1 file changed

`‎src/backend/commands/vacuumlazy.c`

0 commit comments