NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita44dd93

committed

Fix masking of SP-GiST pages during xlog consistency check

spg_mask() didn't take into account that pd_lower equal to SizeOfPageHeaderDatais still valid value. This commit fixes that. Backpatch to 11, wherespg_mask() pg_lower check was introduced.Reported-by: Michael PaquierDiscussion:https://postgr.es/m/20200615131405.GM52676%40paquier.xyzBackpatch-through: 11

1 parent15cb2bd commita44dd93Copy full SHA for a44dd93

File tree

1 file changed

-1

lines changed

src/backend/access/spgist
- spgxlog.c

1 file changed

-1

lines changed

`‎src/backend/access/spgist/spgxlog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1008,6 +1008,6 @@ spg_mask(char *pagedata, BlockNumber blkno)`
`1008`	`1008`	`* Mask the unused space, but only if the page's pd_lower appears to have`
`1009`	`1009`	`* been set correctly.`
`1010`	`1010`	`*/`
`1011`		`-if (pagehdr->pd_lower>SizeOfPageHeaderData)`
	`1011`	`+if (pagehdr->pd_lower >=SizeOfPageHeaderData)`
`1012`	`1012`	`mask_unused_space(page);`
`1013`	`1013`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita44dd93

File tree

1 file changed

1 file changed

`‎src/backend/access/spgist/spgxlog.c`

0 commit comments