NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita40646e

committed

Fix error handling in replacement pthread_barrier_init().

Commit44bf3d5 incorrectly used an errno-style interface when supplyingmissing pthread functionality (i.e. on macOS), but it should check forand return error numbers directly.

1 parent7c544ec commita40646eCopy full SHA for a40646e

File tree

1 file changed

-8

lines changed

src/port
- pthread_barrier_wait.c

1 file changed

-8

lines changed

`‎src/port/pthread_barrier_wait.c`

Lines changed: 6 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,19 +18,17 @@`
`18`	`18`	`int`
`19`	`19`	`pthread_barrier_init(pthread_barrier_tbarrier,constvoidattr,intcount)`
`20`	`20`	`{`
	`21`	`+interror;`
	`22`	`+`
`21`	`23`	`barrier->sense= false;`
`22`	`24`	`barrier->count=count;`
`23`	`25`	`barrier->arrived=0;`
`24`		`-if (pthread_cond_init(&barrier->cond,NULL)<0)`
`25`		`-return-1;`
`26`		`-if (pthread_mutex_init(&barrier->mutex,NULL)<0)`
	`26`	`+if ((error=pthread_cond_init(&barrier->cond,NULL))!=0)`
	`27`	`+returnerror;`
	`28`	`+if ((error=pthread_mutex_init(&barrier->mutex,NULL))!=0)`
`27`	`29`	`{`
`28`		`-intsave_errno=errno;`
`29`		`-`
`30`	`30`	`pthread_cond_destroy(&barrier->cond);`
`31`		`-errno=save_errno;`
`32`		`-`
`33`		`-return-1;`
	`31`	`+returnerror;`
`34`	`32`	`}`
`35`	`33`
`36`	`34`	`return0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita40646e

File tree

1 file changed

1 file changed

`‎src/port/pthread_barrier_wait.c`

0 commit comments