forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commita3e6c6f
committed
BitmapHeapScan: Remove incorrect assert and reset field
04e72ed pushed the skip fetch optimization (allowing bitmap heapscans to operate like index-only scans if none of the underlying data isneeded) into heap AM implementations of bitmap table scan callbacks.04e72ed added an assert that all tuples in blocks eligible for theoptimization had been NULL-filled and emitted by the end of the scan.This assert is incorrect when not all tuples need be scanned to executethe query; for example: a join in which not all inner tuples need to bescanned before skipping to the next outer tuple.Remove the assert and reset the field on which it previously asserted toavoid incorrectly emitting NULL-filled tuples from a previous scan onrescan.Author: Melanie PlagemanReviewed-by: Tomas Vondra, Michael Paquier, Alvaro HerreraReported-by: Melanie PlagemanReproduced-by: Tomas Vondra, Richard GuoDiscussion:https://postgr.es/m/CAMbWs48orzZVXa7-vP9Nt7vQWLTE04Qy4PePaLQYsVNQgo6qRg%40mail.gmail.com1 parentfb5718f commita3e6c6f
3 files changed
+66
-3
lines changedLines changed: 6 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1184 | 1184 |
| |
1185 | 1185 |
| |
1186 | 1186 |
| |
1187 |
| - | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
1188 | 1193 |
| |
1189 | 1194 |
| |
1190 | 1195 |
| |
| |||
1216 | 1221 |
| |
1217 | 1222 |
| |
1218 | 1223 |
| |
1219 |
| - | |
1220 |
| - | |
1221 | 1224 |
| |
1222 | 1225 |
| |
1223 | 1226 |
| |
|
Lines changed: 36 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
7924 | 7924 |
| |
7925 | 7925 |
| |
7926 | 7926 |
| |
| 7927 | + | |
| 7928 | + | |
| 7929 | + | |
| 7930 | + | |
| 7931 | + | |
| 7932 | + | |
| 7933 | + | |
| 7934 | + | |
| 7935 | + | |
| 7936 | + | |
| 7937 | + | |
| 7938 | + | |
| 7939 | + | |
| 7940 | + | |
| 7941 | + | |
| 7942 | + | |
| 7943 | + | |
| 7944 | + | |
| 7945 | + | |
| 7946 | + | |
| 7947 | + | |
| 7948 | + | |
| 7949 | + | |
| 7950 | + | |
| 7951 | + | |
| 7952 | + | |
| 7953 | + | |
| 7954 | + | |
| 7955 | + | |
| 7956 | + | |
| 7957 | + | |
| 7958 | + | |
| 7959 | + | |
| 7960 | + | |
| 7961 | + | |
| 7962 | + |
Lines changed: 24 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2904 | 2904 |
| |
2905 | 2905 |
| |
2906 | 2906 |
| |
| 2907 | + | |
| 2908 | + | |
| 2909 | + | |
| 2910 | + | |
| 2911 | + | |
| 2912 | + | |
| 2913 | + | |
| 2914 | + | |
| 2915 | + | |
| 2916 | + | |
| 2917 | + | |
| 2918 | + | |
| 2919 | + | |
| 2920 | + | |
| 2921 | + | |
| 2922 | + | |
| 2923 | + | |
| 2924 | + | |
| 2925 | + | |
| 2926 | + | |
| 2927 | + | |
| 2928 | + | |
| 2929 | + | |
| 2930 | + |
0 commit comments
Comments
(0)