NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita3a836f

committed

Attempt to fix newly added Memoize regression test

Both drongo and fairywren seem not to like a new regression test addedby2cca95e. These machines show a different number of actual rows inthe EXPLAIN ANALYZE output. Since the number of actual rows is divided bythe number of loops, I suspect this might be due to some platformdependant rounding behavior as the total row count is 5 and the number ofloops is 2. drongo and fairywren seem to be calculating that 5.0 / 2.0 is3, whereas most other machines think the answer is 2.Here we tweak the test query's WHERE clause so it's 4.0 / 2.0 instead.There shouldn't be too much wiggle room for platform dependant-behavior tobe a factor with those numbers.Reported-by: Tom LaneDiscussion:https://postgr.es/m/1035225.1706301718%40sss.pgh.pa.us

1 parent5e444a2 commita3a836fCopy full SHA for a3a836f

File tree

2 files changed

-8

lines changed

src/test/regress
- expected
  - memoize.out
- sql
  - memoize.sql

2 files changed

-8

lines changed

`‎src/test/regress/expected/memoize.out`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -96,14 +96,14 @@ WHERE t1.unique1 < 1000;`
`96`	`96`	`SELECT explain_memoize('`
`97`	`97`	`SELECT COUNT(*),AVG(t2.t1two) FROM tenk1 t1 LEFT JOIN`
`98`	`98`	`LATERAL (`
`99`		`- SELECT t1.two as t1two, * FROM tenk1 t2 WHERE t2.unique1 <5 OFFSET 0`
	`99`	`+ SELECT t1.two as t1two, * FROM tenk1 t2 WHERE t2.unique1 <4 OFFSET 0`
`100`	`100`	`) t2`
`101`	`101`	`ON t1.two = t2.two`
`102`	`102`	`WHERE t1.unique1 < 10;', false);`
`103`	`103`	`explain_memoize`
`104`	`104`	`----------------------------------------------------------------------------------------------`
`105`	`105`	`Aggregate (actual rows=1 loops=N)`
`106`		`- -> Nested Loop Left Join (actual rows=25 loops=N)`
	`106`	`+ -> Nested Loop Left Join (actual rows=20 loops=N)`
`107`	`107`	`-> Index Scan using tenk1_unique1 on tenk1 t1 (actual rows=10 loops=N)`
`108`	`108`	`Index Cond: (unique1 < 10)`
`109`	`109`	`-> Memoize (actual rows=2 loops=N)`
`@@ -113,20 +113,20 @@ WHERE t1.unique1 < 10;', false);`
`113`	`113`	`-> Subquery Scan on t2 (actual rows=2 loops=N)`
`114`	`114`	`Filter: (t1.two = t2.two)`
`115`	`115`	`Rows Removed by Filter: 2`
`116`		`- -> Index Scan using tenk1_unique1 on tenk1 t2_1 (actual rows=5 loops=N)`
`117`		`- Index Cond: (unique1 <5)`
	`116`	`+ -> Index Scan using tenk1_unique1 on tenk1 t2_1 (actual rows=4 loops=N)`
	`117`	`+ Index Cond: (unique1 <4)`
`118`	`118`	`(13 rows)`
`119`	`119`
`120`	`120`	`-- And check we get the expected results.`
`121`	`121`	`SELECT COUNT(*),AVG(t2.t1two) FROM tenk1 t1 LEFT JOIN`
`122`	`122`	`LATERAL (`
`123`		`- SELECT t1.two as t1two, * FROM tenk1 t2 WHERE t2.unique1 <5 OFFSET 0`
	`123`	`+ SELECT t1.two as t1two, * FROM tenk1 t2 WHERE t2.unique1 <4 OFFSET 0`
`124`	`124`	`) t2`
`125`	`125`	`ON t1.two = t2.two`
`126`	`126`	`WHERE t1.unique1 < 10;`
`127`	`127`	`count \| avg`
`128`	`128`	`-------+------------------------`
`129`		`-25 \| 0.40000000000000000000`
	`129`	`+20 \| 0.50000000000000000000`
`130`	`130`	`(1 row)`
`131`	`131`
`132`	`132`	`-- Reduce work_mem and hash_mem_multiplier so that we see some cache evictions`

`‎src/test/regress/sql/memoize.sql`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,15 +61,15 @@ WHERE t1.unique1 < 1000;`
`61`	`61`	`SELECT explain_memoize('`
`62`	`62`	`SELECT COUNT(*),AVG(t2.t1two) FROM tenk1 t1 LEFT JOIN`
`63`	`63`	`LATERAL (`
`64`		`- SELECT t1.two as t1two, * FROM tenk1 t2 WHERE t2.unique1 <5 OFFSET 0`
	`64`	`+ SELECT t1.two as t1two, * FROM tenk1 t2 WHERE t2.unique1 <4 OFFSET 0`
`65`	`65`	`) t2`
`66`	`66`	`ON t1.two = t2.two`
`67`	`67`	`WHERE t1.unique1 < 10;', false);`
`68`	`68`
`69`	`69`	`-- And check we get the expected results.`
`70`	`70`	`SELECTCOUNT(*),AVG(t2.t1two)FROM tenk1 t1LEFT JOIN`
`71`	`71`	`LATERAL (`
`72`		`-SELECTt1.twoas t1two,*FROM tenk1 t2WHEREt2.unique1<5 OFFSET0`
	`72`	`+SELECTt1.twoas t1two,*FROM tenk1 t2WHEREt2.unique1<4 OFFSET0`
`73`	`73`	`) t2`
`74`	`74`	`ONt1.two=t2.two`
`75`	`75`	`WHEREt1.unique1<10;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita3a836f

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/memoize.out`

`‎src/test/regress/sql/memoize.sql`

0 commit comments