NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita396e20

committed

Rename variable for code clarity

When tracking IO timing for WAL, the duration is what we calculatebased on the start and end timestamps, it's not what the variablecontains. Rename the timestamp variable to end to better communicatewhat it contains. Original patch by Krishnakumar with additionalhacking to fix another occurrence by me.Author: Krishnakumar R <kksrcv001@gmail.com>Discussion:https://postgr.es/m/CAPMWgZ9f9o8awrQpjo8oxnNQ=bMDVPx00NE0QcDzvHD_ZrdLPw@mail.gmail.com

1 parent18724af commita396e20Copy full SHA for a396e20

File tree

1 file changed

-6

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-6

lines changed

`‎src/backend/access/transam/xlog.c‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2226,10 +2226,10 @@ XLogWrite(XLogwrtRqst WriteRqst, TimeLineID tli, bool flexible)`
`2226`	`2226`	`*/`
`2227`	`2227`	`if (track_wal_io_timing)`
`2228`	`2228`	`{`
`2229`		`-instr_timeduration;`
	`2229`	`+instr_timeend;`
`2230`	`2230`
`2231`		`-INSTR_TIME_SET_CURRENT(duration);`
`2232`		`-INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_write_time,duration,start);`
	`2231`	`+INSTR_TIME_SET_CURRENT(end);`
	`2232`	`+INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_write_time,end,start);`
`2233`	`2233`	`}`
`2234`	`2234`
`2235`	`2235`	`PendingWalStats.wal_write++;`
`@@ -8252,10 +8252,10 @@ issue_xlog_fsync(int fd, XLogSegNo segno, TimeLineID tli)`
`8252`	`8252`	`*/`
`8253`	`8253`	`if (track_wal_io_timing)`
`8254`	`8254`	`{`
`8255`		`-instr_timeduration;`
	`8255`	`+instr_timeend;`
`8256`	`8256`
`8257`		`-INSTR_TIME_SET_CURRENT(duration);`
`8258`		`-INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time,duration,start);`
	`8257`	`+INSTR_TIME_SET_CURRENT(end);`
	`8258`	`+INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time,end,start);`
`8259`	`8259`	`}`
`8260`	`8260`
`8261`	`8261`	`PendingWalStats.wal_sync++;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita396e20

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c‎`

0 commit comments