NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita376960

committed

Suppress compiler warning for get_am_type_string().

Compilers that don't know that elog(ERROR) doesn't return complainedthat this function might fail to return a value. Per buildfarm.While at it, const-ify the function's declaration, since the intentis evidently to always return a constant string.

1 parent0ecd3fe commita376960Copy full SHA for a376960

File tree

1 file changed

-3

lines changed

src/backend/commands
- amcmds.c

1 file changed

-3

lines changed

`‎src/backend/commands/amcmds.c`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`
`31`	`31`
`32`	`32`	`staticOidlookup_index_am_handler_func(List*handler_name,charamtype);`
`33`		`-staticchar*get_am_type_string(charamtype);`
	`33`	`+staticconstchar*get_am_type_string(charamtype);`
`34`	`34`
`35`	`35`
`36`	`36`	`/*`
`@@ -217,9 +217,9 @@ get_am_name(Oid amOid)`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`/*`
`220`		`- * Convert single charater access method type into string for error reporting.`
	`220`	`+ * Convert single-character access method type into string for error reporting.`
`221`	`221`	`*/`
`222`		`-staticchar*`
	`222`	`+staticconstchar*`
`223`	`223`	`get_am_type_string(charamtype)`
`224`	`224`	`{`
`225`	`225`	`switch (amtype)`
`@@ -229,6 +229,7 @@ get_am_type_string(char amtype)`
`229`	`229`	`default:`
`230`	`230`	`/* shouldn't happen */`
`231`	`231`	`elog(ERROR,"invalid access method type '%c'",amtype);`
	`232`	`+returnNULL;/* keep compiler quiet */`
`232`	`233`	`}`
`233`	`234`	`}`
`234`	`235`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita376960

File tree

1 file changed

1 file changed

`‎src/backend/commands/amcmds.c`

0 commit comments