Commita2f9123

michaelpq

authored and

pull[bot]

committed

Revert "Improve error message on snapshot import in snapmgr.c"

This reverts commita0d87bc, following a remark from Andres Frendthat the new error can be triggered with an incorrect SET TRANSACTIONSNAPSHOT command without being really helpful for the user as it usesthe internal file name.Discussion:https://postgr.es/m/20230914020724.hlks7vunitvtbbz4@awork3.anarazel.deBackpatch-through: 11

1 parenta26d376 commita2f9123Copy full SHA for a2f9123

File tree

1 file changed

-3

lines changed

src/backend/utils/time
- snapmgr.c

1 file changed

-3

lines changed

`‎src/backend/utils/time/snapmgr.c‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1391,9 +1391,8 @@ ImportSnapshot(const char *idstr)`
`1391`	`1391`	`f=AllocateFile(path,PG_BINARY_R);`
`1392`	`1392`	`if (!f)`
`1393`	`1393`	`ereport(ERROR,`
`1394`		`-(errcode_for_file_access(),`
`1395`		`-errmsg("could not open file \"%s\" for reading: %m",`
`1396`		`-path)));`
	`1394`	`+(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
	`1395`	`+errmsg("invalid snapshot identifier: \"%s\"",idstr)));`
`1397`	`1396`
`1398`	`1397`	`/* get the size of the file so that we know how much memory we need */`
`1399`	`1398`	`if (fstat(fileno(f),&stat_buf))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita2f9123

File tree

1 file changed

1 file changed

`‎src/backend/utils/time/snapmgr.c‎`

0 commit comments