NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita2d75b6

committed

Remove useless pg_strdup() operations.

split_to_stringlist() doesn't modify its first argument nor expect itto remain valid after exit, so there's no need to duplicate the optargstring at the call sites. Per Coverity. (This has been wrong all along,but commit052cc22 changed the useless calls from "strdup" to"pg_strdup", which apparently made Coverity think it's a new bug.It's not, but it's also not worth back-patching.)

1 parente21db14 commita2d75b6Copy full SHA for a2d75b6

File tree

1 file changed

-2

lines changed

src/test/regress
- pg_regress.c

1 file changed

-2

lines changed

`‎src/test/regress/pg_regress.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2064,7 +2064,7 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2064`	`2064`	`* before we add the specified one.`
`2065`	`2065`	`*/`
`2066`	`2066`	`free_stringlist(&dblist);`
`2067`		`-split_to_stringlist(pg_strdup(optarg),", ",&dblist);`
	`2067`	`+split_to_stringlist(optarg,", ",&dblist);`
`2068`	`2068`	`break;`
`2069`	`2069`	`case2:`
`2070`	`2070`	`debug= true;`
`@@ -2114,7 +2114,7 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2114`	`2114`	`dlpath=pg_strdup(optarg);`
`2115`	`2115`	`break;`
`2116`	`2116`	`case18:`
`2117`		`-split_to_stringlist(pg_strdup(optarg),", ",&extraroles);`
	`2117`	`+split_to_stringlist(optarg,", ",&extraroles);`
`2118`	`2118`	`break;`
`2119`	`2119`	`case19:`
`2120`	`2120`	`add_stringlist_item(&temp_configs,optarg);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita2d75b6

File tree

1 file changed

1 file changed

`‎src/test/regress/pg_regress.c`

0 commit comments