forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commita27048c
committed
More cleanup of 'ThisTimeLineID'.
In XLogCtlData, rename the structure member ThisTimeLineID toInsertTimeLineID and update the comments to make clear that it's onlyexpected to be set after recovery is complete.In StartupXLOG, replace the local variables ThisTimeLineID andPrevTimeLineID with new local variables replayTLI and newTLI. In theold scheme, ThisTimeLineID was the replay TLI until we created a newtimeline, and after that the replay TLI was in PrevTimeLineID. Now,replayTLI is the TLI from which we last replayed WAL throughout theentire function, and newTLI is either that, or the new timeline createdupon promotion.Remove some misleading comments from the comment block just above whererecoveryTargetTimeLineGoal and friends are declared. It's becomeincorrect, not only because ThisTimeLineID as a variable is now gone,but also because the rmgr code does not care about ThisTimeLineID andhas not since what used to be the TLI field in the page header wasrepurposed to store the page checksum.Add a comment GetFlushRecPtr that it's only supposed to be used innormal running, and an assertion to verify that this is so.Per some ideas from Michael Paquier and some of my own. Review byMichael Paquier also.Discussion:http://postgr.es/m/CA+TgmoY1a2d1AnVR3tJcKmGGkhj7GGrwiNwjtKr21dxOuLBzCQ@mail.gmail.com1 parent733e039 commita27048c
1 file changed
+62
-63
lines changed0 commit comments
Comments
(0)