NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita267894

committed

Fix pg_recvlogical avoidance of superfluous Standby Status Update.

The defect suppressed a Standby Status Update message when bytes flushedto disk had changed but bytes received had not changed. Ifpg_recvlogical then exited with no intervening Standby Status Update,the next pg_recvlogical repeated already-flushed records. The defectcould also cause superfluous messages, which are functionally harmless.Back-patch to 9.5 (all supported versions).Discussion:https://postgr.es/m/20200502221647.GA3941274@rfd.leadboat.com

1 parent357012e commita267894Copy full SHA for a267894

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- pg_recvlogical.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/pg_recvlogical.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ sendFeedback(PGconn *conn, TimestampTz now, bool force, bool replyRequested)`
`128`	`128`	`*/`
`129`	`129`	`if (!force&&`
`130`	`130`	`last_written_lsn==output_written_lsn&&`
`131`		`-last_fsync_lsn!=output_fsync_lsn)`
	`131`	`+last_fsync_lsn==output_fsync_lsn)`
`132`	`132`	`return true;`
`133`	`133`
`134`	`134`	`if (verbose)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita267894

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/pg_recvlogical.c`

0 commit comments