NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita260208

committed

Document and clean up gistsplit.c.

Improve comments, rename some variables and functions, slightly simplifya couple of APIs, in an attempt to make this code readable by people otherthan its original author.Even though this is essentially just cosmetic, back-patch to all activebranches, because otherwise it's going to make back-patching future fixesin this file very painful.

1 parentccb5def commita260208Copy full SHA for a260208

File tree

4 files changed

+320

-172

lines changed

src
- backend/access/gist
  - gist.c
  - gistsplit.c
- include/access
  - gist.h
  - gist_private.h

4 files changed

+320

-172

lines changed

`‎src/backend/access/gist/gist.c`

Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -945,18 +945,12 @@ gistSplit(Relation r,`
`945`	`945`	`IndexTuple*lvectup,`
`946`	`946`	`*rvectup;`
`947`	`947`	`GistSplitVectorv;`
`948`		`-GistEntryVector*entryvec;`
`949`	`948`	`inti;`
`950`	`949`	`SplitedPageLayout*res=NULL;`
`951`	`950`
`952`		`-/* generate the item array */`
`953`		`-entryvec=palloc(GEVHDRSZ+ (len+1)*sizeof(GISTENTRY));`
`954`		`-entryvec->n=len+1;`
`955`		`-`
`956`	`951`	`memset(v.spl_lisnull, TRUE,sizeof(bool)*giststate->tupdesc->natts);`
`957`	`952`	`memset(v.spl_risnull, TRUE,sizeof(bool)*giststate->tupdesc->natts);`
`958`		`-gistSplitByKey(r,page,itup,len,giststate,`
`959`		`-&v,entryvec,0);`
	`953`	`+gistSplitByKey(r,page,itup,len,giststate,&v,0);`
`960`	`954`
`961`	`955`	`/* form left and right vector */`
`962`	`956`	`lvectup= (IndexTuple)palloc(sizeof(IndexTuple) (len+1));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita260208

File tree

4 files changed

4 files changed

`‎src/backend/access/gist/gist.c`

0 commit comments