NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita21c3e3

Thomas G. Lockhart

committed

Allow 't', 'T', and even/odd ASCII characters to denote true/false

rather than just 't' and 'T'. This allows yes/no and 1/0 to be interpreted as one might expect.Clean up function declarations to use bool as the type for arguments and return values.

1 parent8fe55ef commita21c3e3Copy full SHA for a21c3e3

File tree

1 file changed

+11

-8

lines changed

src/backend/utils/adt
- bool.c

1 file changed

+11

-8

lines changed

`‎src/backend/utils/adt/bool.c`

Lines changed: 11 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/bool.c,v 1.6 1997/09/08 02:30:26 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/bool.c,v 1.7 1997/10/09 05:06:12 thomas Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -23,20 +23,23 @@`
`23`	`23`
`24`	`24`	`/*`
`25`	`25`	`*boolin- converts "t" or "f" to 1 or 0`
	`26`	`+ *`
	`27`	`+ * Check explicitly for "true/TRUE" and allow any odd ASCII value to be "true".`
	`28`	`+ * This handles "true/false", "yes/no", "1/0". - thomas 1997-10-05`
`26`	`29`	`*/`
`27`	`30`	`bool`
`28`	`31`	`boolin(char*b)`
`29`	`32`	`{`
`30`	`33`	`if (b==NULL)`
`31`	`34`	`elog(WARN,"Bad input string for type bool");`
`32`		`-return ((bool) (b=='t')\|\| (b=='T'));`
	`35`	`+return ((bool) (((b)=='t')\|\| ((b)=='T')\|\| ((*b)&1)));`
`33`	`36`	`}`
`34`	`37`
`35`	`38`	`/*`
`36`	`39`	`*boolout- converts 1 or 0 to "t" or "f"`
`37`	`40`	`*/`
`38`		`-char*`
`39`		`-boolout(longb)`
	`41`	`+char*`
	`42`	`+boolout(boolb)`
`40`	`43`	`{`
`41`	`44`	`charresult= (char)palloc(2);`
`42`	`45`
`@@ -50,25 +53,25 @@ boolout(long b)`
`50`	`53`	`*****************************************************************************/`
`51`	`54`
`52`	`55`	`bool`
`53`		`-booleq(int8arg1,int8arg2)`
	`56`	`+booleq(boolarg1,boolarg2)`
`54`	`57`	`{`
`55`	`58`	`return (arg1==arg2);`
`56`	`59`	`}`
`57`	`60`
`58`	`61`	`bool`
`59`		`-boolne(int8arg1,int8arg2)`
	`62`	`+boolne(boolarg1,boolarg2)`
`60`	`63`	`{`
`61`	`64`	`return (arg1!=arg2);`
`62`	`65`	`}`
`63`	`66`
`64`	`67`	`bool`
`65`		`-boollt(int8arg1,int8arg2)`
	`68`	`+boollt(boolarg1,boolarg2)`
`66`	`69`	`{`
`67`	`70`	`return (arg1<arg2);`
`68`	`71`	`}`
`69`	`72`
`70`	`73`	`bool`
`71`		`-boolgt(int8arg1,int8arg2)`
	`74`	`+boolgt(boolarg1,boolarg2)`
`72`	`75`	`{`
`73`	`76`	`return (arg1>arg2);`
`74`	`77`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita21c3e3

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/bool.c`

0 commit comments