Commita1f5851

committed

Replace ad-hoc atof() code with call to float4in, per Andrew Dunstan.

1 parent85b2fac commita1f5851Copy full SHA for a1f5851

File tree

-17

lines changed

-17

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -418,8 +418,7 @@ SELECT '1 e7'::seg AS seg;`
`418`	`418`	`ERROR: bad seg representation`
`419`	`419`	`DETAIL: syntax error at or near "e"`
`420`	`420`	`SELECT '1e700'::seg AS seg;`
`421`		`-ERROR: syntax error`
`422`		`-DETAIL: numeric value 1e700 unrepresentable`
	`421`	`+ERROR: "1e700" is out of range for type real`
`423`	`422`	`--`
`424`	`423`	`-- testing the operators`
`425`	`424`	`--`

Lines changed: 8 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,8 @@`
`5`	`5`
`6`	`6`	`#include<math.h>`
`7`	`7`
	`8`	`+#include"fmgr.h"`
	`9`	`+#include"utils/builtins.h"`
`8`	`10`	`#include"segdata.h"`
`9`	`11`
`10`	`12`	`#undef yylex/* failure to redefine yylex will result in calling the*/`
`@@ -129,22 +131,13 @@ deviation:`
`129`	`131`	`%%`
`130`	`132`
`131`	`133`
`132`		`-floatseg_atof (char *value ) {`
`133`		`-float result;`
`134`		`-char buf = (char )palloc(256);`
	`134`	`+float`
	`135`	`+seg_atof(char *value)`
	`136`	`+{`
	`137`	`+Datum datum;`
`135`	`138`
`136`		`- errno =0;`
`137`		`-sscanf(value,"%f", &result);`
`138`		`-`
`139`		`-if ( errno ) {`
`140`		`-snprintf(buf,256,"numeric value %s unrepresentable", value);`
`141`		`-ereport(ERROR,`
`142`		`- (errcode(ERRCODE_SYNTAX_ERROR),`
`143`		`-errmsg("syntax error"),`
`144`		`-errdetail("%s", buf)));`
`145`		`- }`
`146`		`-`
`147`		`-return result;`
	`139`	`+datum =DirectFunctionCall1(float4in,CStringGetDatum(value));`
	`140`	`+returnDatumGetFloat4(datum);`
`148`	`141`	`}`
`149`	`142`
`150`	`143`

Comments

(0)