Commita1bb3d5

committed

Schedule ShutdownXLOG() in single user mode using before_shmem_exit().

Previously on_shmem_exit() was used. The upcoming shared memory stats patchuses DSM segments to store stats, which can not be used after thedsm_backend_shutdown() call in shmem_exit(). There does not seem to be anyreason to do ShutdownXLOG() via on_shmem_exit(), so change it.Author: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/20210405092914.mmxqe7j56lsjfsej@alap3.anarazel.deDiscussion:https://postgr.es/m/20210803023612.iziacxk5syn2r4ut@alap3.anarazel.de

1 parentfa91d4c commita1bb3d5Copy full SHA for a1bb3d5

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -638,7 +638,11 @@ InitPostgres(const char in_dbname, Oid dboid, const char username,`
`638`	`638`	`/* Reset CurrentResourceOwner to nothing for the moment */`
`639`	`639`	`CurrentResourceOwner=NULL;`
`640`	`640`
`641`		`-on_shmem_exit(ShutdownXLOG,0);`
	`641`	`+/*`
	`642`	`+ * Use before_shmem_exit() so that ShutdownXLOG() can rely on DSM`
	`643`	`+ * segments etc to work (which in turn is required for pgstats).`
	`644`	`+ */`
	`645`	`+before_shmem_exit(ShutdownXLOG,0);`
`642`	`646`	`}`
`643`	`647`
`644`	`648`	`/*`

Comments

(0)