forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commita1a8d02
committed
Adjust "pgstat wait timeout" message to be a translatable LOG message.
Per discussion, change the log level of this message to be LOG not WARNING.The main point of this change is to avoid causing buildfarm run failureswhen the stats collector is exceptionally slow to respond, which it notinfrequently is on some of the smaller/slower buildfarm members.This change does lose notice to an interactive user when his stats queryis looking at out-of-date stats, but the majority opinion (not necessarilythat of yours truly) is that WARNING messages would probably not getnoticed anyway on heavily loaded production systems. A LOG message atleast ensures that the problem is recorded somewhere where bulk auditingfor the issue is possible.Also, instead of an untranslated "pgstat wait timeout" message, providea translatable and hopefully more understandable message "using stalestatistics instead of current ones because stats collector is notresponding". The original text was written hastily under the assumptionthat it would never really happen in practice, which we now know to beunduly optimistic.Back-patch to all active branches, since we've seen the buildfarm issuein all branches.1 parentcebb3f0 commita1a8d02
1 file changed
+3
-1
lines changedLines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3694 | 3694 | | |
3695 | 3695 | | |
3696 | 3696 | | |
3697 | | - | |
| 3697 | + | |
| 3698 | + | |
| 3699 | + | |
3698 | 3700 | | |
3699 | 3701 | | |
3700 | 3702 | | |
| |||
0 commit comments
Comments
(0)