NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita190738

committed

Fix out-of-array-bounds compiler warning

Since the array length check is using a post-increment operator, thecompiler complains that there's a potential write to one element beyondthe end of the array. This is not possible currently: the only path tothis function is through pg_get_object_address(), which already verifiesthat the input array is no more than two elements in length. Still, abug is a bug.No idea why my compiler doesn't complain about this ...Pointed out by Dead Rasheed and Peter Eisentraut

1 parenta61fd53 commita190738Copy full SHA for a190738

File tree

1 file changed

-1

lines changed

src/backend/catalog
- objectaddress.c

1 file changed

-1

lines changed

`‎src/backend/catalog/objectaddress.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1428,7 +1428,7 @@ get_object_address_opf_member(ObjectType objtype,`
`1428`	`1428`	`typenames[i]=strVal(lfirst(cell));`
`1429`	`1429`	`typaddr=get_object_address_type(OBJECT_TYPE,cell,missing_ok);`
`1430`	`1430`	`typeoids[i]=typaddr.objectId;`
`1431`		`-if (i++ >=2)`
	`1431`	`+if (++i >=2)`
`1432`	`1432`	`break;`
`1433`	`1433`	`}`
`1434`	`1434`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita190738

File tree

1 file changed

1 file changed

`‎src/backend/catalog/objectaddress.c`

0 commit comments