Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita17aa50

Browse files
author
Amit Kapila
committed
Improve the comments in 004_subscription.pl.
It was not clear whether the subscriptions in the upgraded instance werethe ones that retained the previous subscription's properties.Author: Peter SmithReviewed-by: Vignesh C, Alvaro HerreraDiscussion:https://postgr.es/m/CAHut+Pu1usLPHRySPTacY1K_Q-ddSRXNFhmj_2u1NfqBC1ytng@mail.gmail.com
1 parent2889fd2 commita17aa50

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

‎src/bin/pg_upgrade/t/004_subscription.pl‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@
108108
# ------------------------------------------------------
109109
# Check that pg_upgrade is successful when all tables are in ready or in
110110
# init state (tab_upgraded1 table is in ready state and tab_upgraded2 table is
111-
# in init state) along with retaining the replication origin's remote lsn
112-
#andsubscription's running status.
111+
# in init state) along with retaining the replication origin's remote lsn,
112+
# subscription's running status, and failover option.
113113
# ------------------------------------------------------
114114
command_ok(
115115
[
@@ -137,15 +137,15 @@
137137

138138
$new_sub->start;
139139

140-
# The subscription's running status and failover option should be preserved.
141-
#Old subscription regress_sub1 should have enabled and failover as true while
142-
#old subscriptionregress_sub2 should haveenabled and failover as false.
140+
# The subscription's running status and failover option should be preserved
141+
#in the upgraded instance. So regress_sub1 should still have subenabled and
142+
#subfailover set to true, whileregress_sub2 should haveboth set to false.
143143
$result =
144144
$new_sub->safe_psql('postgres',
145145
"SELECT subname, subenabled, subfailover FROM pg_subscription ORDER BY subname");
146146
is($result,qq(regress_sub1|t|t
147147
regress_sub2|f|f),
148-
"check that the subscription's running status are preserved");
148+
"check that the subscription's running statusand failoverare preserved");
149149

150150
my$sub_oid =$new_sub->safe_psql('postgres',
151151
"SELECT oid FROM pg_subscription WHERE subname = 'regress_sub2'");

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp