NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita1176c6

committed

Simplify some maths in xlogreader.c

An LSN was calculated from a segment number, a segment size and aposition offset, matching exactly the LSN given by the caller ofXLogReaderValidatePageHeader(). This change removes the extra LSNcalculation, relying only on the LSN given by the function callerinstead.Author: Bharath RupireddyReviewed-by: Richard Guo, Álvaro Herrera, Kyotaro HoriguchiDiscussion:https://postgr.es/m/CALj2ACXuh4Ms9j9sxMYdtHEe=5sFcyrs-GAHyADu_A_G71kZTg@mail.gmail.com

1 parent94fd253 commita1176c6Copy full SHA for a1176c6

File tree

1 file changed

-4

lines changed

src/backend/access/transam
- xlogreader.c

1 file changed

-4

lines changed

`‎src/backend/access/transam/xlogreader.c`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1210,7 +1210,6 @@ bool`
`1210`	`1210`	`XLogReaderValidatePageHeader(XLogReaderState*state,XLogRecPtrrecptr,`
`1211`	`1211`	`char*phdr)`
`1212`	`1212`	`{`
`1213`		`-XLogRecPtrrecaddr;`
`1214`	`1213`	`XLogSegNosegno;`
`1215`	`1214`	`int32offset;`
`1216`	`1215`	`XLogPageHeaderhdr= (XLogPageHeader)phdr;`
`@@ -1220,8 +1219,6 @@ XLogReaderValidatePageHeader(XLogReaderState *state, XLogRecPtr recptr,`
`1220`	`1219`	`XLByteToSeg(recptr,segno,state->segcxt.ws_segsize);`
`1221`	`1220`	`offset=XLogSegmentOffset(recptr,state->segcxt.ws_segsize);`
`1222`	`1221`
`1223`		`-XLogSegNoOffsetToRecPtr(segno,offset,state->segcxt.ws_segsize,recaddr);`
`1224`		`-`
`1225`	`1222`	`if (hdr->xlp_magic!=XLOG_PAGE_MAGIC)`
`1226`	`1223`	`{`
`1227`	`1224`	`charfname[MAXFNAMELEN];`
`@@ -1296,7 +1293,7 @@ XLogReaderValidatePageHeader(XLogReaderState *state, XLogRecPtr recptr,`
`1296`	`1293`	`* check typically fails when an old WAL segment is recycled, and hasn't`
`1297`	`1294`	`* yet been overwritten with new data yet.`
`1298`	`1295`	`*/`
`1299`		`-if (hdr->xlp_pageaddr!=recaddr)`
	`1296`	`+if (hdr->xlp_pageaddr!=recptr)`
`1300`	`1297`	`{`
`1301`	`1298`	`charfname[MAXFNAMELEN];`
`1302`	`1299`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita1176c6

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlogreader.c`

0 commit comments