Commita096813

committed

Log regression.diffs in 027_stream_regress.pl.

To help diagnose the reasons for a regression test failure inside thisTAP test, dump the contents of regression.diffs to the log. While theCI scripts show it automatically, the build farm client does not.Reviewed-by: Andrew Dunstan <andrew@dunslane.net>Discussion:https://postgr.es/m/CA%2BhUKGLsrWbiCcMxBLRBAP6Z%3DykFRHWzdmP9YKujSKoSnEJECQ%40mail.gmail.com

1 parent7fa3db3 commita096813Copy full SHA for a096813

File tree

+21

-9

lines changed

+21

-9

lines changed

Lines changed: 21 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,15 +53,27 @@`
`53`	`53`
`54`	`54`	`# Run the regression tests against the primary.`
`55`	`55`	`my$extra_opts =$ENV{EXTRA_REGRESS_OPTS} \|\|"";`
`56`		`-system_or_bail($ENV{PG_REGRESS} ."$extra_opts" .`
`57`		`-"--dlpath=\"$dlpath\"" .`
`58`		`-"--bindir=" .`
`59`		`-"--host=" .$node_primary->host ."" .`
`60`		`-"--port=" .$node_primary->port ."" .`
`61`		`-"--schedule=../regress/parallel_schedule" .`
`62`		`-"--max-concurrent-tests=20" .`
`63`		`-"--inputdir=../regress" .`
`64`		`-"--outputdir=\"$outputdir\"");`
	`56`	`+my$rc =system($ENV{PG_REGRESS} ."$extra_opts" .`
	`57`	`+"--dlpath=\"$dlpath\"" .`
	`58`	`+"--bindir=" .`
	`59`	`+"--host=" .$node_primary->host ."" .`
	`60`	`+"--port=" .$node_primary->port ."" .`
	`61`	`+"--schedule=../regress/parallel_schedule" .`
	`62`	`+"--max-concurrent-tests=20" .`
	`63`	`+"--inputdir=../regress" .`
	`64`	`+"--outputdir=\"$outputdir\"");`
	`65`	`+if ($rc != 0)`
	`66`	`+{`
	`67`	`+# Dump out the regression diffs file, if there is one`
	`68`	`+my$diffs ="$outputdir/regression.diffs";`
	`69`	`+if (-e$diffs)`
	`70`	`+{`
	`71`	`+print"=== dumping$diffs ===\n";`
	`72`	`+print slurp_file($diffs);`
	`73`	`+print"=== EOF ===\n";`
	`74`	`+}`
	`75`	`+}`
	`76`	`+is($rc, 0,'regression tests pass');`
`65`	`77`
`66`	`78`	`# Clobber all sequences with their next value, so that we don't have`
`67`	`79`	`# differences between nodes due to caching.`

Comments

(0)