NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita03b3b6

committed

Avoid potential UCollator leak for older ICU versions.

ICU versions 53 and earlier rely on icu_set_collation_attributes() toprocess the attributes in the locale string. Avoid leaking thealready-opened UCollator object if an error is encountered.Discussion:https://postgr.es/m/04182066-7655-344a-b8b7-040b1b2490fb%40enterprisedb.comReviewed-by: Peter Eisentraut

1 parent9a24289 commita03b3b6Copy full SHA for a03b3b6

File tree

1 file changed

-0

lines changed

src/backend/utils/adt
- pg_locale.c

1 file changed

-0

lines changed

`‎src/backend/utils/adt/pg_locale.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2810,9 +2810,12 @@ icu_set_collation_attributes(UCollator collator, const char loc)`
`2810`	`2810`	`* message across ICU versions.`
`2811`	`2811`	`*/`
`2812`	`2812`	`if (U_FAILURE(status))`
	`2813`	`+{`
	`2814`	`+ucol_close(collator);`
`2813`	`2815`	`ereport(ERROR,`
`2814`	`2816`	`(errmsg("could not open collator for locale \"%s\": %s",`
`2815`	`2817`	`loc,u_errorName(status))));`
	`2818`	`+}`
`2816`	`2819`	`}`
`2817`	`2820`	`}`
`2818`	`2821`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita03b3b6

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/pg_locale.c`

0 commit comments