NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commita02740e

committed

Avoid reference to nonexistent array element in ExecInitAgg().

When considering an empty grouping set, we fetchedphasedata->eqfunctions[-1]. Because the eqfunctions array ispalloc'd, that would always be an aset pointer in released versions,and thus the code accidentally failed to malfunction (since it woulddo nothing unless it found a null pointer). Nonetheless this seemslike trouble waiting to happen, so add a check for length == 0.It's depressing that our valgrind testing did not catch this.Maybe we should reconsider the choice to not mark that word NOACCESS?Richard GuoDiscussion:https://postgr.es/m/CAMbWs4-vZuuPOZsKOYnSAaPYGKhmacxhki+vpOKk0O7rymccXQ@mail.gmail.com

1 parentfdaba0a commita02740eCopy full SHA for a02740e

File tree

1 file changed

-0

lines changed

src/backend/executor
- nodeAgg.c

1 file changed

-0

lines changed

`‎src/backend/executor/nodeAgg.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3574,6 +3574,11 @@ ExecInitAgg(Agg node, EState estate, int eflags)`
`3574`	`3574`	`{`
`3575`	`3575`	`intlength=phasedata->gset_lengths[i];`
`3576`	`3576`
	`3577`	`+/* nothing to do for empty grouping set */`
	`3578`	`+if (length==0)`
	`3579`	`+continue;`
	`3580`	`+`
	`3581`	`+/* if we already had one of this length, it'll do */`
`3577`	`3582`	`if (phasedata->eqfunctions[length-1]!=NULL)`
`3578`	`3583`	`continue;`
`3579`	`3584`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita02740e

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeAgg.c`

0 commit comments