Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9fb8cd2

Browse files
committed
Fix unportable setvbuf() usage in initdb.
In yesterday's commit2dc4f01, I triedto force buffering of stdout/stderr in initdb to be what it is bydefault when the program is run interactively on Unix (since that's howmost manual testing is done). This tripped over the fact that Windowsdoesn't support _IOLBF mode. We dealt with that a long time ago insyslogger.c by falling back to unbuffered mode on Windows. Export thatsolution in port.h and use it in initdb.Back-patch to 8.4, like the previous commit.
1 parentf1f3bcb commit9fb8cd2

File tree

3 files changed

+21
-18
lines changed

3 files changed

+21
-18
lines changed

‎src/backend/postmaster/syslogger.c

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,6 @@
4545
#include"utils/ps_status.h"
4646
#include"utils/timestamp.h"
4747

48-
/*
49-
* We really want line-buffered mode for logfile output, but Windows does
50-
* not have it, and interprets _IOLBF as _IOFBF (bozos). So use _IONBF
51-
* instead on Windows.
52-
*/
53-
#ifdefWIN32
54-
#defineLBF_MODE_IONBF
55-
#else
56-
#defineLBF_MODE_IOLBF
57-
#endif
58-
5948
/*
6049
* We read() into a temp buffer twice as big as a chunk, so that any fragment
6150
* left after processing can be moved down to the front and we'll still have
@@ -561,7 +550,7 @@ SysLogger_Start(void)
561550
(errmsg("could not create log file \"%s\": %m",
562551
filename))));
563552

564-
setvbuf(syslogFile,NULL,LBF_MODE,0);
553+
setvbuf(syslogFile,NULL,PG_IOLBF,0);
565554

566555
pfree(filename);
567556

@@ -709,7 +698,7 @@ syslogger_parseArgs(int argc, char *argv[])
709698
if (fd!=-1)
710699
{
711700
syslogFile=fdopen(fd,"a");
712-
setvbuf(syslogFile,NULL,LBF_MODE,0);
701+
setvbuf(syslogFile,NULL,PG_IOLBF,0);
713702
}
714703
#else/* WIN32 */
715704
fd=atoi(*argv++);
@@ -719,7 +708,7 @@ syslogger_parseArgs(int argc, char *argv[])
719708
if (fd>0)
720709
{
721710
syslogFile=fdopen(fd,"a");
722-
setvbuf(syslogFile,NULL,LBF_MODE,0);
711+
setvbuf(syslogFile,NULL,PG_IOLBF,0);
723712
}
724713
}
725714
#endif/* WIN32 */
@@ -1062,7 +1051,7 @@ open_csvlogfile(void)
10621051
(errmsg("could not create log file \"%s\": %m",
10631052
filename))));
10641053

1065-
setvbuf(fh,NULL,LBF_MODE,0);
1054+
setvbuf(fh,NULL,PG_IOLBF,0);
10661055

10671056
#ifdefWIN32
10681057
_setmode(_fileno(fh),_O_TEXT);/* use CRLF line endings on Windows */
@@ -1148,7 +1137,7 @@ logfile_rotate(bool time_based_rotation, int size_rotation_for)
11481137
return;
11491138
}
11501139

1151-
setvbuf(fh,NULL,LBF_MODE,0);
1140+
setvbuf(fh,NULL,PG_IOLBF,0);
11521141

11531142
#ifdefWIN32
11541143
_setmode(_fileno(fh),_O_TEXT);/* use CRLF line endings on Windows */
@@ -1205,7 +1194,7 @@ logfile_rotate(bool time_based_rotation, int size_rotation_for)
12051194
return;
12061195
}
12071196

1208-
setvbuf(fh,NULL,LBF_MODE,0);
1197+
setvbuf(fh,NULL,PG_IOLBF,0);
12091198

12101199
#ifdefWIN32
12111200
_setmode(_fileno(fh),_O_TEXT);/* use CRLF line endings on Windows */

‎src/bin/initdb/initdb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2470,7 +2470,7 @@ main(int argc, char *argv[])
24702470
* unexpected output ordering when, eg, output is redirected to a file.
24712471
* POSIX says we must do this before any other usage of these files.
24722472
*/
2473-
setvbuf(stdout,NULL,_IOLBF,0);
2473+
setvbuf(stdout,NULL,PG_IOLBF,0);
24742474
setvbuf(stderr,NULL,_IONBF,0);
24752475

24762476
progname=get_progname(argv[0]);

‎src/include/port.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,20 @@ extern intgettimeofday(struct timeval * tp, struct timezone * tzp);
352352
#defineclosesocket close
353353
#endif/* WIN32 */
354354

355+
/*
356+
* On Windows, setvbuf() does not support _IOLBF mode, and interprets that
357+
* as _IOFBF. To add insult to injury, setvbuf(file, NULL, _IOFBF, 0)
358+
* crashes outright if "parameter validation" is enabled. Therefore, in
359+
* places where we'd like to select line-buffered mode, we fall back to
360+
* unbuffered mode instead on Windows. Always use PG_IOLBF not _IOLBF
361+
* directly in order to implement this behavior.
362+
*/
363+
#ifndefWIN32
364+
#definePG_IOLBF_IOLBF
365+
#else
366+
#definePG_IOLBF_IONBF
367+
#endif
368+
355369
/*
356370
* Default "extern" declarations or macro substitutes for library routines.
357371
* When necessary, these routines are provided by files in src/port/.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp