NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9fa9353

committed

Don't allocate memory inside an Assert() iff in a critical section.

HeapTupleHeaderGetCmax() asserts that it is only used if the tuple hasbeen updated by the current transaction. That check is correct andsensible but requires allocating memory if xmax is a multixact. Whenwal_level is set to logical cmax needs to be included in a wal record, generated inside a critical section, which can trigger the assertionadded in4a170ee.Reported-By: Steve Singer

1 parent0564bbe commit9fa9353Copy full SHA for 9fa9353

File tree

1 file changed

-1

lines changed

src/backend/utils/time
- combocid.c

1 file changed

-1

lines changed

`‎src/backend/utils/time/combocid.c`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`
`42`	`42`	`#include"postgres.h"`
`43`	`43`
	`44`	`+#include"miscadmin.h"`
`44`	`45`	`#include"access/htup_details.h"`
`45`	`46`	`#include"access/xact.h"`
`46`	`47`	`#include"utils/combocid.h"`
`@@ -119,7 +120,14 @@ HeapTupleHeaderGetCmax(HeapTupleHeader tup)`
`119`	`120`	`CommandIdcid=HeapTupleHeaderGetRawCommandId(tup);`
`120`	`121`
`121`	`122`	`Assert(!(tup->t_infomask&HEAP_MOVED));`
`122`		`-Assert(TransactionIdIsCurrentTransactionId(HeapTupleHeaderGetUpdateXid(tup)));`
	`123`	`+/*`
	`124`	`+ * Because GetUpdateXid() performs memory allocations if xmax is a`
	`125`	`+ * multixact we can't Assert() if we're inside a critical section. This`
	`126`	`+ * weakens the check, but not using GetCmax() inside one would complicate`
	`127`	`+ * things too much.`
	`128`	`+ */`
	`129`	`+Assert(CritSectionCount>0\|\|`
	`130`	`+TransactionIdIsCurrentTransactionId(HeapTupleHeaderGetUpdateXid(tup)));`
`123`	`131`
`124`	`132`	`if (tup->t_infomask&HEAP_COMBOCID)`
`125`	`133`	`returnGetRealCmax(cid);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9fa9353

File tree

1 file changed

1 file changed

`‎src/backend/utils/time/combocid.c`

0 commit comments