NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9f65aaa

committed

Remove unused argument "isSlice" from transformAssignmentSubscripts()

Sincec7aba7c, the transform method used during parse analysis of asubcripting construct has moved from transformAssignmentSubscripts() tothe per-type transform method (arrays or arbitrary types) the step thatchecks for slicing support, but transformAssignmentSubscripts() has kepttraces of it. Removing it simplifies the code, so let's clean up allthat.Author: Zhang MingliReviewed-by: Richard GuoDiscussion:https://postgr.es/m/0d7041ac-c704-48ad-86fd-e05feddf08ed@Spark

1 parent035ce1f commit9f65aaaCopy full SHA for 9f65aaa

File tree

1 file changed

-9

lines changed

src/backend/parser
- parse_target.c

1 file changed

-9

lines changed

`‎src/backend/parser/parse_target.c‎`

Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ static Node transformAssignmentSubscripts(ParseState pstate,`
`41`	`41`	`int32targetTypMod,`
`42`	`42`	`OidtargetCollation,`
`43`	`43`	`List*subscripts,`
`44`		`-boolisSlice,`
`45`	`44`	`List*indirection,`
`46`	`45`	`ListCell*next_indirection,`
`47`	`46`	`Node*rhs,`
`@@ -697,7 +696,6 @@ transformAssignmentIndirection(ParseState *pstate,`
`697`	`696`	`{`
`698`	`697`	`Node*result;`
`699`	`698`	`List*subscripts=NIL;`
`700`		`-boolisSlice= false;`
`701`	`699`	`ListCell*i;`
`702`	`700`
`703`	`701`	`if (indirection_cell&& !basenode)`
`@@ -727,11 +725,7 @@ transformAssignmentIndirection(ParseState *pstate,`
`727`	`725`	`Node*n=lfirst(i);`
`728`	`726`
`729`	`727`	`if (IsA(n,A_Indices))`
`730`		`-{`
`731`	`728`	`subscripts=lappend(subscripts,n);`
`732`		`-if (((A_Indices*)n)->is_slice)`
`733`		`-isSlice= true;`
`734`		`-}`
`735`	`729`	`elseif (IsA(n,A_Star))`
`736`	`730`	`{`
`737`	`731`	`ereport(ERROR,`
`@@ -763,7 +757,6 @@ transformAssignmentIndirection(ParseState *pstate,`
`763`	`757`	`targetTypMod,`
`764`	`758`	`targetCollation,`
`765`	`759`	`subscripts,`
`766`		`-isSlice,`
`767`	`760`	`indirection,`
`768`	`761`	`i,`
`769`	`762`	`rhs,`
`@@ -853,7 +846,6 @@ transformAssignmentIndirection(ParseState *pstate,`
`853`	`846`	`targetTypMod,`
`854`	`847`	`targetCollation,`
`855`	`848`	`subscripts,`
`856`		`-isSlice,`
`857`	`849`	`indirection,`
`858`	`850`	`NULL,`
`859`	`851`	`rhs,`
`@@ -907,7 +899,6 @@ transformAssignmentSubscripts(ParseState *pstate,`
`907`	`899`	`int32targetTypMod,`
`908`	`900`	`OidtargetCollation,`
`909`	`901`	`List*subscripts,`
`910`		`-boolisSlice,`
`911`	`902`	`List*indirection,`
`912`	`903`	`ListCell*next_indirection,`
`913`	`904`	`Node*rhs,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9f65aaa

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_target.c‎`

0 commit comments