Commit9f35e42

committed

Remove unnecessary smgropen() calls

1 parent5fce30e commit9f35e42Copy full SHA for 9f35e42

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -633,8 +633,6 @@ heapam_relation_copy_data(Relation rel, const RelFileLocator *newrlocator)`
`633`	`633`	`{`
`634`	`634`	`SMgrRelationdstrel;`
`635`	`635`
`636`		`-dstrel=smgropen(*newrlocator,rel->rd_backend);`
`637`		`-`
`638`	`636`	`/*`
`639`	`637`	`* Since we copy the file directly without looking at the shared buffers,`
`640`	`638`	`* we'd better first flush out any pages of the source relation that are`
`@@ -650,7 +648,7 @@ heapam_relation_copy_data(Relation rel, const RelFileLocator *newrlocator)`
`650`	`648`	`* NOTE: any conflict in relfilenumber value will be caught in`
`651`	`649`	`* RelationCreateStorage().`
`652`	`650`	`*/`
`653`		`-RelationCreateStorage(*newrlocator,rel->rd_rel->relpersistence, true);`
	`651`	`+dstrel=RelationCreateStorage(*newrlocator,rel->rd_rel->relpersistence, true);`
`654`	`652`
`655`	`653`	`/* copy main fork */`
`656`	`654`	`RelationCopyStorage(RelationGetSmgr(rel),dstrel,MAIN_FORKNUM,`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -15747,8 +15747,6 @@ index_copy_data(Relation rel, RelFileLocator newrlocator)`
`15747`	`15747`	`{`
`15748`	`15748`	`SMgrRelation dstrel;`
`15749`	`15749`
`15750`		`-dstrel = smgropen(newrlocator, rel->rd_backend);`
`15751`		`-`
`15752`	`15750`	`/*`
`15753`	`15751`	`* Since we copy the file directly without looking at the shared buffers,`
`15754`	`15752`	`* we'd better first flush out any pages of the source relation that are`
`@@ -15764,7 +15762,7 @@ index_copy_data(Relation rel, RelFileLocator newrlocator)`
`15764`	`15762`	`* NOTE: any conflict in relfilenumber value will be caught in`
`15765`	`15763`	`* RelationCreateStorage().`
`15766`	`15764`	`*/`
`15767`		`-RelationCreateStorage(newrlocator, rel->rd_rel->relpersistence, true);`
	`15765`	`+dstrel =RelationCreateStorage(newrlocator, rel->rd_rel->relpersistence, true);`
`15768`	`15766`
`15769`	`15767`	`/* copy main fork */`
`15770`	`15768`	`RelationCopyStorage(RelationGetSmgr(rel), dstrel, MAIN_FORKNUM,`

Comments

(0)