NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9f2c4ed

committed

Remove bogus Assert in foreign key cloning code

This Assert was trying to ensure that the number of columns in the foreignkey being cloned was the same number of attributes in the parentRel. Ofcourse, it's perfectly valid to have columns in the table which are notpart of the foreign key constraint. It appears that this Assert wasmisunderstanding that.Reported-by: Rajkumar RaghuwanshiReviewed-by: amul sulDiscussion:https://postgr.es/m/CAKcux6=z1dtiWw5BOpqDx-U6KTiq+zD0Y2m810zUtWL+giVXWA@mail.gmail.com

1 parentaaf069a commit9f2c4edCopy full SHA for 9f2c4ed

File tree

1 file changed

-1

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9043,7 +9043,7 @@ CloneFkReferenced(Relation parentRel, Relation partitionRel)`
`9043`	`9043`	`conpfeqop,`
`9044`	`9044`	`conppeqop,`
`9045`	`9045`	`conffeqop);`
`9046`		`-Assert(numfks == attmap->maplen);`
	`9046`	`+`
`9047`	`9047`	`for (int i = 0; i < numfks; i++)`
`9048`	`9048`	`mapped_confkey[i] = attmap->attnums[confkey[i] - 1];`
`9049`	`9049`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9f2c4ed

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments