Commit9f23619

committed

Fix type of iterator variable in SH_START_ITERATE

Also add comment to make the reasoning behind the Assert() more explicit (perTom).Reported-by: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAocXNJ6s1VLz+hMamLAQAiewRoW17OJ6-+9GACKfj6iPQ@mail.gmail.comBackpatch: 11-

1 parent2d3983a commit9f23619Copy full SHA for 9f23619

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -772,15 +772,14 @@ SH_DELETE(SH_TYPE * tb, SH_KEY_TYPE key)`
`772`	`772`	`SH_SCOPEvoid`
`773`	`773`	`SH_START_ITERATE(SH_TYPEtb,SH_ITERATORiter)`
`774`	`774`	`{`
`775`		`-inti;`
`776`	`775`	`uint64startelem=PG_UINT64_MAX;`
`777`	`776`
`778`	`777`	`/*`
`779`	`778`	`* Search for the first empty element. As deletions during iterations are`
`780`	`779`	`* supported, we want to start/end at an element that cannot be affected`
`781`	`780`	`* by elements being shifted.`
`782`	`781`	`*/`
`783`		`-for (i=0;i<tb->size;i++)`
	`782`	`+for (uint32i=0;i<tb->size;i++)`
`784`	`783`	`{`
`785`	`784`	`SH_ELEMENT_TYPE*entry=&tb->data[i];`
`786`	`785`
`@@ -791,6 +790,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter)`
`791`	`790`	`}`
`792`	`791`	`}`
`793`	`792`
	`793`	`+/* we should have found an empty element */`
`794`	`794`	`Assert(startelem<SH_MAX_SIZE);`
`795`	`795`
`796`	`796`	`/*`

Comments

(0)